Bug 203202 - results.webkit.org: Add ability to display time on bubbles
Summary: results.webkit.org: Add ability to display time on bubbles
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-10-21 12:48 PDT by Jonathan Bedard
Modified: 2019-10-21 17:22 PDT (History)
4 users (show)

See Also:

Attachments
Patch (3.82 KB, patch)
2019-10-21 13:01 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Screen shot (519.22 KB, image/png)
2019-10-21 13:53 PDT, Jonathan Bedard 		no flags Details
Patch (4.28 KB, patch)
2019-10-21 14:29 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Screen shot (collapsed) (198.52 KB, image/png)
2019-10-21 14:31 PDT, Jonathan Bedard 		no flags Details
Patch (4.29 KB, patch)
2019-10-21 14:46 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch for landing (4.29 KB, patch)
2019-10-21 15:16 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2019-10-21 12:48:39 PDT 
For tests which are close to timing out, it's useful to have an easy way to visualize the time it took to run a test.
Comment 1 Jonathan Bedard 2019-10-21 12:49:06 PDT 
<rdar://problem/56436621>
Comment 2 Jonathan Bedard 2019-10-21 13:01:05 PDT 
Created attachment 381432 [details]
Patch
Comment 3 Aakash Jain 2019-10-21 13:19:40 PDT 
Can you add a screenshot indicating how it would look like?
Comment 4 Jonathan Bedard 2019-10-21 13:53:10 PDT 
Created attachment 381446 [details]
Screen shot
Comment 5 Jonathan Bedard 2019-10-21 14:29:56 PDT 
Created attachment 381454 [details]
Patch
Comment 6 Jonathan Bedard 2019-10-21 14:31:31 PDT 
Created attachment 381456 [details]
Screen shot (collapsed)
Comment 7 Jonathan Bedard 2019-10-21 14:46:14 PDT 
Created attachment 381459 [details]
Patch
Comment 8 Aakash Jain 2019-10-21 14:47:55 PDT 
Comment on attachment 381459 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381459&action=review

rs=me

> Tools/resultsdbpy/resultsdbpy/view/static/js/timeline.js:909
> +                <label>Show test times</label>

Would it be better to label it: "Show test times (in s)"
Comment 9 Alexey Proskuryakov 2019-10-21 15:01:07 PDT 
> Would it be better to label it: "Show test times (in s)"

That seems unusual and detached from the actual number to me. With the old dashboard, it was clear enough based on the range of values.
Comment 10 Jonathan Bedard 2019-10-21 15:11:17 PDT 
(In reply to Alexey Proskuryakov from comment #9)
> > Would it be better to label it: "Show test times (in s)"
> 
> That seems unusual and detached from the actual number to me. With the old
> dashboard, it was clear enough based on the range of values.

The patch up for review now displays seconds, so it's going to be between 1 and 30 (except for special tests that override the default timeout) which I think is the behavior of the old dashboard.
Comment 11 Jonathan Bedard 2019-10-21 15:16:24 PDT 
Created attachment 381467 [details]
Patch for landing
Comment 12 WebKit Commit Bot 2019-10-21 17:21:24 PDT 
The commit-queue encountered the following flaky tests while processing attachment 381467 [details]:

fetch/fetch-worker-crash.html bug 187257 (author: youennf@gmail.com)
The commit-queue is continuing to process your patch.
Comment 13 WebKit Commit Bot 2019-10-21 17:22:16 PDT 
Comment on attachment 381467 [details]
Patch for landing

Clearing flags on attachment: 381467

Committed r251401: <https://trac.webkit.org/changeset/251401>
Comment 14 WebKit Commit Bot 2019-10-21 17:22:18 PDT 
All reviewed patches have been landed.  Closing bug.