Bug 194536 - SourceCode should be copied when generating bytecode for functions
Summary: SourceCode should be copied when generating bytecode for functions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tadeu Zagallo
URL:
Keywords: InRadar
: 194575 (view as bug list)
Depends on:
Blocks:
 
Reported: 2019-02-12 05:32 PST by Tadeu Zagallo
Modified: 2019-02-13 04:31 PST (History)
7 users (show)

See Also:


Attachments
Patch (1.86 KB, patch)
2019-02-12 05:43 PST, Tadeu Zagallo
no flags Details | Formatted Diff | Diff
Patch for landing (2.01 KB, patch)
2019-02-13 03:26 PST, Tadeu Zagallo
no flags Details | Formatted Diff | Diff
Patch for landing (2.00 KB, patch)
2019-02-13 03:30 PST, Tadeu Zagallo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tadeu Zagallo 2019-02-12 05:32:30 PST
...
Comment 1 Tadeu Zagallo 2019-02-12 05:43:30 PST
Created attachment 361793 [details]
Patch
Comment 2 Saam Barati 2019-02-13 02:04:47 PST
Please add a fix me pointing to:
https://bugs.webkit.org/show_bug.cgi?id=194576
Comment 3 Saam Barati 2019-02-13 02:05:20 PST
*** Bug 194575 has been marked as a duplicate of this bug. ***
Comment 4 Saam Barati 2019-02-13 02:07:18 PST
It would be nice if some of our bytecode cache tests used the code path of creating all functions up front to get better test coverage
Comment 5 Tadeu Zagallo 2019-02-13 03:26:46 PST
Created attachment 361908 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2019-02-13 03:29:05 PST
Comment on attachment 361908 [details]
Patch for landing

Rejecting attachment 361908 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 361908, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/JavaScriptCore/ChangeLog contains OOPS!.

Full output: https://webkit-queues.webkit.org/results/11133542
Comment 7 Tadeu Zagallo 2019-02-13 03:30:03 PST
(In reply to Saam Barati from comment #4)
> It would be nice if some of our bytecode cache tests used the code path of
> creating all functions up front to get better test coverage

Yes, I agree. I tried replacing the current bytecode-cache tests with that when I added the API, but it failed on tests that loaded other files dynamically. We should think of other way of doing that.
Comment 8 Tadeu Zagallo 2019-02-13 03:30:41 PST
Created attachment 361909 [details]
Patch for landing
Comment 9 WebKit Commit Bot 2019-02-13 04:20:26 PST
The commit-queue encountered the following flaky tests while processing attachment 361909 [details]:

fetch/fetch-worker-crash.html bug 187257 (author: youennf@gmail.com)
The commit-queue is continuing to process your patch.
Comment 10 WebKit Commit Bot 2019-02-13 04:21:06 PST
Comment on attachment 361909 [details]
Patch for landing

Clearing flags on attachment: 361909

Committed r241431: <https://trac.webkit.org/changeset/241431>
Comment 11 WebKit Commit Bot 2019-02-13 04:21:08 PST
All reviewed patches have been landed.  Closing bug.
Comment 12 Radar WebKit Bug Importer 2019-02-13 04:31:49 PST
<rdar://problem/48034682>