Bug 208804 - Remove SampleBufferDisplayLayer sync IPC
Summary: Remove SampleBufferDisplayLayer sync IPC
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-09 05:00 PDT by youenn fablet
Modified: 2020-03-10 07:43 PDT (History)
9 users (show)

See Also:


Attachments
Patch (35.09 KB, patch)
2020-03-09 05:16 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Patch for landing (35.18 KB, patch)
2020-03-10 06:08 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Patch for landing (35.17 KB, patch)
2020-03-10 07:03 PDT, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2020-03-09 05:00:35 PDT
Remove SampleBufferDisplayLayer sync IPC
Comment 1 youenn fablet 2020-03-09 05:16:13 PDT
Created attachment 393022 [details]
Patch
Comment 2 Eric Carlson 2020-03-09 06:13:25 PDT
Comment on attachment 393022 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393022&action=review

r=me if the bots are happy

> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:385
> +        [m_boundsChangeListener begin: m_sampleBufferDisplayLayer->rootLayer()];

Nit: don't need a space after the ':'
Comment 3 youenn fablet 2020-03-10 06:08:33 PDT
Created attachment 393140 [details]
Patch for landing
Comment 4 WebKit Commit Bot 2020-03-10 07:00:00 PDT
Comment on attachment 393140 [details]
Patch for landing

Rejecting attachment 393140 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 393140, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!.

Full output: https://webkit-queues.webkit.org/results/13337675
Comment 5 youenn fablet 2020-03-10 07:03:28 PDT
Created attachment 393145 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2020-03-10 07:42:14 PDT
The commit-queue encountered the following flaky tests while processing attachment 393145 [details]:

fetch/fetch-worker-crash.html bug 187257 (author: youennf@gmail.com)
The commit-queue is continuing to process your patch.
Comment 7 WebKit Commit Bot 2020-03-10 07:42:52 PDT
Comment on attachment 393145 [details]
Patch for landing

Clearing flags on attachment: 393145

Committed r258208: <https://trac.webkit.org/changeset/258208>
Comment 8 WebKit Commit Bot 2020-03-10 07:42:54 PDT
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2020-03-10 07:43:20 PDT
<rdar://problem/60272200>