Crash in Page::updateRendering when document has no domWindow

[Sunny He]

rdar://56999099

[Sunny He]

Created attachment 391223 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 391223 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391223&action=review

> Source/WebCore/page/Page.cpp:1334
> +        if (document.domWindow()) {

Can we use an early return instead?

[Said Abou-Hallawa]

Comment on attachment 391223 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391223&action=review

>> Source/WebCore/page/Page.cpp:1334
>> +        if (document.domWindow()) {
> 
> Can we use an early return instead?

Should this be in forEachDocument()? Is there a reason to run any rendering update step for a document which does not have a window?

[Ryosuke Niwa]

(In reply to Said Abou-Hallawa from comment #3)
> Comment on attachment 391223 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=391223&action=review
> 
> >> Source/WebCore/page/Page.cpp:1334
> >> +        if (document.domWindow()) {
> > 
> > Can we use an early return instead?
> 
> Should this be in forEachDocument()? Is there a reason to run any rendering
> update step for a document which does not have a window?

I don’t think we want to do that there because it’s used in other places than Page::updateRendering.

[Sunny He]

Created attachment 391365 [details]
Patch

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 391365 [details]:

editing/spelling/spellcheck-input-search-crash.html bug 207995 (authors: [e-mail], [e-mail], [e-mail], and [e-mail])
fetch/fetch-worker-crash.html bug 187257 (author: [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 391365 [details]
Patch

Clearing flags on attachment: 391365

Committed r257123: <https://trac.webkit.org/changeset/257123>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.