Bug 197566 - [iOS] set the default maximum camera count to 1 for enumerateDevices
Summary: [iOS] set the default maximum camera count to 1 for enumerateDevices
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-05-03 09:52 PDT by youenn fablet
Modified: 2019-05-03 16:14 PDT (History)
4 users (show)

See Also:

Attachments
Patch (4.02 KB, patch)
2019-05-03 10:22 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (3.95 KB, patch)
2019-05-03 15:20 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2019-05-03 09:52:04 PDT 
[iOS] set the default maximum camera count to 1 for enumerateDevices
Comment 1 youenn fablet 2019-05-03 10:22:04 PDT 
Created attachment 368946 [details]
Patch
Comment 2 Eric Carlson 2019-05-03 10:53:53 PDT 
Comment on attachment 368946 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=368946&action=review

> Source/WebKit/ChangeLog:8
> +        The previous number for iOS was 2 as there are a front and back camera.

Nit: s/there are a front/there is a front/
Comment 3 youenn fablet 2019-05-03 15:20:40 PDT 
Created attachment 369003 [details]
Patch for landing
Comment 4 WebKit Commit Bot 2019-05-03 16:12:51 PDT 
The commit-queue encountered the following flaky tests while processing attachment 369003 [details]:

fetch/fetch-worker-crash.html bug 187257 (author: youennf@gmail.com)
The commit-queue is continuing to process your patch.
Comment 5 WebKit Commit Bot 2019-05-03 16:13:42 PDT 
Comment on attachment 369003 [details]
Patch for landing

Clearing flags on attachment: 369003

Committed r244935: <https://trac.webkit.org/changeset/244935>
Comment 6 WebKit Commit Bot 2019-05-03 16:13:44 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-05-03 16:14:19 PDT 
<rdar://problem/50461108>