Bug 93095 - [V8] meta: Refactor V8 bindings
Summary: [V8] meta: Refactor V8 bindings
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on: 75793 85330 93093 93211 93215 93217 93218 93220 93223 93226 93239 93254 93312 93318 93326 93333 93334 93342 93343 93592 93595 93598 93615 93803 93805 93807 93810 93818 93821 93822 93824 93835 93836 93839 94436 94571 94573 94574 94588 94710 97057
Blocks:
  Show dependency tree / graph
 
Reported: 2012-08-03 05:21 PDT by Kentaro Hara
Modified: 2013-09-01 10:49 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-08-03 05:21:33 PDT 
I'm planning to refactor V8 bindings, blocking this meta bug. Let's discuss high-level stuff here.

Examples:
- Remove v8::Undefined(), v8::Handle<v8::Value>(), ...etc and use v8Undefined() everywhere.
- Clean up V8Binding.h and document what each method does (just like v8.h).
- Rename classes and files for clarification and consistency (e.g. SharedPersistent => OwnPersistent, WindowShell => WindowProxy, V8BindingsPerIsolateData => V8PerIsolateData, etc)
- Remove hand-written ref()/deref() and Persistent::New()/Dispose().
- Fix a bunch of incorrect use of v8::TryCatch().
- Simplify V8Parameter and V8ParameterBase.
- ...
Comment 1 Adam Barth 2012-08-03 09:46:34 PDT 
That all sounds great.  Can I add one thing?  We should break V8Binding.h down into a bunch of smaller headers.  At the moment, it's a bit of a dumping ground for random functions.
Comment 2 Kentaro Hara 2012-08-03 09:49:46 PDT 
(In reply to comment #1)
> That all sounds great.  Can I add one thing?  We should break V8Binding.h down into a bunch of smaller headers.  At the moment, it's a bit of a dumping ground for random functions.

I do agree. At least I'd like to split out "V8 Binding APIs" from V8Binding.h to another header with a good documentation in each method (just like v8.h).
Comment 3 Anders Carlsson 2013-09-01 10:49:20 PDT 
V8 is gone.