Bug 93807 - [V8] Remove V8BindingHelpers
Summary: [V8] Remove V8BindingHelpers
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
Depends on:
Blocks: 93095
  Show dependency treegraph
Reported: 2012-08-13 02:11 PDT by Kentaro Hara
Modified: 2012-08-13 19:24 PDT (History)
5 users (show)

See Also:

Patch (8.71 KB, patch)
2012-08-13 02:14 PDT, Kentaro Hara
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-08-13 02:11:20 PDT
V8BindingHelpers contains toV8Context() and toV8Proxy(), which are used by NPV8Object.cpp only.

(1) Move these methods to NPV8Object.cpp as static methods.
(2) Remove V8BindingHelpers.{h,cpp}.
Comment 1 Kentaro Hara 2012-08-13 02:14:28 PDT
Created attachment 157943 [details]
Comment 2 Adam Barth 2012-08-13 10:27:47 PDT
Comment on attachment 157943 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=157943&action=review

> Source/WebCore/bindings/v8/NPV8Object.cpp:67
> +    if (!domWindow || !domWindow->frame() || domWindow != domWindow->frame()->domWindow())

This line of code is so broken.  I'll fix it as part of Bug 75793.
Comment 3 Kentaro Hara 2012-08-13 17:45:01 PDT
Committed r125479: <http://trac.webkit.org/changeset/125479>