WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
75793
[meta] DOMWindow::m_securityOrigin must die!
https://bugs.webkit.org/show_bug.cgi?id=75793
Summary
[meta] DOMWindow::m_securityOrigin must die!
Adam Barth
Reported
2012-01-08 01:52:11 PST
[meta] DOMWindow::m_securityOrigin must die
Attachments
crazy large proof-of-concept
(63.51 KB, patch)
2012-01-08 01:53 PST
,
Adam Barth
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Adam Barth
Comment 1
2012-01-08 01:53:02 PST
Created
attachment 121574
[details]
crazy large proof-of-concept
Adam Barth
Comment 2
2012-01-08 01:55:17 PST
It's crazy that DOMWindow has its own secret version of m_securityOrigin. We should only have one canonical place to store that state (which is the SecurityContext base class). Unfortunately, removing this state triggers a massive yak shave to move a lot of bindings code away from using DOMWindow as a context object and towards using ScriptExecutionContext, which is the right thing anyway. I'll post the real patches on separate bugs that block this one.
Adam Barth
Comment 3
2012-08-02 11:09:22 PDT
I'm going to try this again. I'm going to take a somewhat long path to make this happen, but hopefully I'll improve a bunch of things about the bindings along the way.
Adam Barth
Comment 4
2012-08-14 13:18:22 PDT
As of <
http://trac.webkit.org/changeset/125592
>, DOMWindow::m_securityOrigin is now dead. I'm going to use this meta bug to various related cleanup patches now that we're "over the hump."
Dimitri Glazkov (Google)
Comment 5
2012-08-14 13:43:20 PDT
(In reply to
comment #4
)
> As of <
http://trac.webkit.org/changeset/125592
>, DOMWindow::m_securityOrigin is now dead. I'm going to use this meta bug to various related cleanup patches now that we're "over the hump."
Whoa.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug