Bug 93016 - The generic bindings shouldn't use templates
Summary: The generic bindings shouldn't use templates
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 75793
  Show dependency tree / graph
 
Reported: 2012-08-02 12:08 PDT by Adam Barth
Modified: 2012-08-02 13:49 PDT (History)
10 users (show)

See Also:

Attachments
Patch (75.73 KB, patch)
2012-08-02 12:12 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2012-08-02 12:08:07 PDT 
The generic bindings shouldn't use templates
Comment 1 Adam Barth 2012-08-02 12:12:01 PDT 
Created attachment 156136 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-08-02 12:21:45 PDT 
Comment on attachment 156136 [details]
Patch

LGTM, but where is JSC/BindingState?  Does JSC not use this yet?  Your ChangeLog is not clear on this part of the history.
Comment 3 Adam Barth 2012-08-02 13:03:06 PDT 
> LGTM, but where is JSC/BindingState?  Does JSC not use this yet?  Your ChangeLog is not clear on this part of the history.

JSC doesn't use this yet.  I'm hoping to change that as part of this process, starting by making the code more attractive.
Comment 4 Adam Barth 2012-08-02 13:49:27 PDT 
Comment on attachment 156136 [details]
Patch

Clearing flags on attachment: 156136

Committed r124492: <http://trac.webkit.org/changeset/124492>
Comment 5 Adam Barth 2012-08-02 13:49:52 PDT 
All reviewed patches have been landed.  Closing bug.