Bug 93079 - [V8] Re-wire "target" half of the same-origin security check through Document rather than DOMWindow
Summary: [V8] Re-wire "target" half of the same-origin security check through Document...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on: 92189 93152
Blocks: 75793
  Show dependency treegraph
 
Reported: 2012-08-03 01:34 PDT by Adam Barth
Modified: 2012-08-04 00:32 PDT (History)
5 users (show)

See Also:


Attachments
Remarkably close (7.07 KB, patch)
2012-08-03 01:34 PDT, Adam Barth
no flags Details | Formatted Diff | Diff
Patch (7.64 KB, patch)
2012-08-03 02:23 PDT, Adam Barth
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from gce-cq-03 (324.56 KB, application/zip)
2012-08-03 22:32 PDT, WebKit Review Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2012-08-03 01:34:39 PDT
[V8] Re-wire "target" half of the same-origin security check through Document rather than DOMWindow
Comment 1 Adam Barth 2012-08-03 01:34:58 PDT
Created attachment 156287 [details]
Remarkably close
Comment 2 Adam Barth 2012-08-03 02:23:47 PDT
Created attachment 156297 [details]
Patch
Comment 3 Eric Seidel (no email) 2012-08-03 02:26:37 PDT
Comment on attachment 156297 [details]
Patch

LGTM.
Comment 4 WebKit Review Bot 2012-08-03 04:18:04 PDT
Comment on attachment 156297 [details]
Patch

Clearing flags on attachment: 156297

Committed r124594: <http://trac.webkit.org/changeset/124594>
Comment 5 WebKit Review Bot 2012-08-03 04:18:08 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 WebKit Review Bot 2012-08-03 13:01:04 PDT
Re-opened since this is blocked by 93152
Comment 7 Adam Barth 2012-08-03 15:57:13 PDT
The test failure is because of Bug 92189.
Comment 8 Adam Barth 2012-08-03 21:36:57 PDT
Comment on attachment 156297 [details]
Patch

This should be safe to land again.
Comment 9 WebKit Review Bot 2012-08-03 22:32:52 PDT
Comment on attachment 156297 [details]
Patch

Rejecting attachment 156297 [details] from commit-queue.

New failing tests:
http/tests/cache/post-redirect-get.php
http/tests/cache/post-with-cached-subresources.php
fast/events/dispatch-message-string-data.html
Full output: http://queues.webkit.org/results/13439034
Comment 10 WebKit Review Bot 2012-08-03 22:32:56 PDT
Created attachment 156515 [details]
Archive of layout-test-results from gce-cq-03

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: gce-cq-03  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Comment 11 WebKit Review Bot 2012-08-04 00:31:58 PDT
Comment on attachment 156297 [details]
Patch

Clearing flags on attachment: 156297

Committed r124693: <http://trac.webkit.org/changeset/124693>
Comment 12 WebKit Review Bot 2012-08-04 00:32:03 PDT
All reviewed patches have been landed.  Closing bug.