Bug 93038 - V8 bindings code that tries to find its context should use BindingState functions rather than V8Proxy
Summary: V8 bindings code that tries to find its context should use BindingState funct...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 75793
  Show dependency treegraph
 
Reported: 2012-08-02 15:52 PDT by Adam Barth
Modified: 2012-08-02 18:51 PDT (History)
8 users (show)

See Also:


Attachments
Patch (13.00 KB, patch)
2012-08-02 15:55 PDT, Adam Barth
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from gce-cr-linux-07 (418.58 KB, application/zip)
2012-08-02 16:58 PDT, WebKit Review Bot
no flags Details
Patch for landing (12.91 KB, patch)
2012-08-02 17:43 PDT, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2012-08-02 15:52:58 PDT
V8 bindings code that tries to find its context should use BindingState functions rather than V8Proxy
Comment 1 Adam Barth 2012-08-02 15:55:17 PDT
Created attachment 156186 [details]
Patch
Comment 2 WebKit Review Bot 2012-08-02 16:58:44 PDT
Comment on attachment 156186 [details]
Patch

Attachment 156186 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13419652

New failing tests:
http/tests/misc/iframe-domain-test.html
http/tests/security/cookies/document-open.html
http/tests/security/xss-DENIED-xsl-document-securityOrigin.xml
http/tests/security/aboutBlank/security-context-window-open.html
http/tests/security/aboutBlank/security-context-with-base-tag.html
http/tests/security/aboutBlank/security-context-grandchildren-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren.html
http/tests/security/aboutBlank/security-context-grandchildren-alias.html
http/tests/security/aboutBlank/security-context.html
http/tests/security/xss-DENIED-xsl-external-entity-redirect.xml
Comment 3 WebKit Review Bot 2012-08-02 16:58:48 PDT
Created attachment 156209 [details]
Archive of layout-test-results from gce-cr-linux-07

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-07  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Comment 4 Adam Barth 2012-08-02 17:41:19 PDT
Comment on attachment 156186 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=156186&action=review

> Source/WebCore/bindings/v8/custom/V8HTMLDocumentCustom.cpp:168
> -    Frame* frame = V8Proxy::retrieveFrameForCallingContext();
> +    Frame* frame = currentFrame(BindingState::instance());

Looks like I made a typo on this line.  This should be activeFrame like the other two examples in this file.  Yay tests!
Comment 5 Adam Barth 2012-08-02 17:43:03 PDT
Created attachment 156218 [details]
Patch for landing
Comment 6 WebKit Review Bot 2012-08-02 18:51:52 PDT
Comment on attachment 156218 [details]
Patch for landing

Clearing flags on attachment: 156218

Committed r124547: <http://trac.webkit.org/changeset/124547>
Comment 7 WebKit Review Bot 2012-08-02 18:51:56 PDT
All reviewed patches have been landed.  Closing bug.