Bug 93382 - Rewire the same-origin checks for the JavaScriptCore bindings through BindingSecurity
Summary: Rewire the same-origin checks for the JavaScriptCore bindings through Binding...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on: 93654
Blocks: 75793 93407
  Show dependency tree / graph
 
Reported: 2012-08-07 12:17 PDT by Adam Barth
Modified: 2012-08-09 14:23 PDT (History)
7 users (show)

See Also:

Attachments
Patch (5.09 KB, patch)
2012-08-07 12:23 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
Patch (5.06 KB, patch)
2012-08-07 12:25 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
hopefully builds on EFL now (5.54 KB, patch)
2012-08-07 13:30 PDT, Adam Barth 		eric: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2012-08-07 12:17:21 PDT 
Rewire the same-origin checks for the JavaScriptCore bindings through BindingSecurity
Comment 1 Adam Barth 2012-08-07 12:23:48 PDT 
Created attachment 156972 [details]
Patch
Comment 2 Adam Barth 2012-08-07 12:25:09 PDT 
Created attachment 156973 [details]
Patch
Comment 3 Gyuyoung Kim 2012-08-07 12:47:02 PDT 
Comment on attachment 156973 [details]
Patch

Attachment 156973 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/13445851
Comment 4 Adam Barth 2012-08-07 13:30:43 PDT 
Created attachment 156989 [details]
hopefully builds on EFL now
Comment 5 Eric Seidel (no email) 2012-08-07 13:52:08 PDT 
Comment on attachment 156989 [details]
hopefully builds on EFL now

I wonder what, if any, perf affect this has on DOM benchmarks.
Comment 6 Adam Barth 2012-08-07 14:03:29 PDT 
> I wonder what, if any, perf affect this has on DOM benchmarks.

I'll run the perf tests before landing, but I don't expect any trouble.
Comment 7 Adam Barth 2012-08-07 16:12:17 PDT 
The work to rewrite allowsAccessFrom through BindingSecurity is in Bug 93407.
Comment 8 Sam Weinig 2012-08-07 17:25:39 PDT 
This seems OK to me, but I would like to see the extra indirect go away.  A follow up patch would be fine for that.
Comment 9 Adam Barth 2012-08-07 22:24:33 PDT 
Thanks.  Will do.
Comment 10 Adam Barth 2012-08-08 17:41:09 PDT 
Committed r125126: <http://trac.webkit.org/changeset/125126>
Comment 11 Csaba Osztrogonác 2012-08-09 14:15:53 PDT 
(In reply to comment #10)
> Committed r125126: <http://trac.webkit.org/changeset/125126>

It caused an assertion on Qt and on GTK. Could you check it, please? https://bugs.webkit.org/show_bug.cgi?id=93654
Comment 12 Adam Barth 2012-08-09 14:23:17 PDT 
> It caused an assertion on Qt and on GTK. Could you check it, please? https://bugs.webkit.org/show_bug.cgi?id=93654

Certainly.