93666 – DOMWindow should be owned by the Document, not the Frame

Bug 93666 - DOMWindow should be owned by the Document, not the Frame

Summary: DOMWindow should be owned by the Document, not the Frame

Attachments
work in progress (4.66 KB, patch) 2012-08-09 16:38 PDT, Adam Barth	no flags	Details \| Formatted Diff \| Diff
still crashes a lot :) (6.51 KB, patch) 2012-08-09 18:03 PDT, Adam Barth	no flags	Details \| Formatted Diff \| Diff
crashes less (19.23 KB, patch) 2012-08-10 04:33 PDT, Adam Barth	no flags	Details \| Formatted Diff \| Diff
maybe, possibly, works (21.81 KB, patch) 2012-08-10 16:23 PDT, Adam Barth	no flags	Details \| Formatted Diff \| Diff
another approach (27.57 KB, patch) 2012-08-13 16:30 PDT, Adam Barth	no flags	Details \| Formatted Diff \| Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Adam Barth 2012-08-09 16:37:13 PDT

DOMWindow should be owned by the Document, not the Frame

Comment 1 Adam Barth 2012-08-09 16:38:17 PDT

Created attachment 157576 [details]
work in progress

Comment 2 Adam Barth 2012-08-09 17:43:12 PDT

In this patch, I'm going to keep the same lifetime for all the objects and just move the owning reference from Frame to Document.

Comment 3 Adam Barth 2012-08-09 18:03:36 PDT

Created attachment 157600 [details]
still crashes a lot :)

Comment 4 Adam Barth 2012-08-10 04:33:41 PDT

Created attachment 157702 [details]
crashes less

Comment 5 Adam Barth 2012-08-10 16:23:28 PDT

Created attachment 157831 [details]
maybe, possibly, works

Comment 6 Adam Barth 2012-08-13 16:30:08 PDT

Created attachment 158142 [details]
another approach

Comment 7 Adam Barth 2012-08-13 17:35:25 PDT

Ok, it looks like it's much easier to fix Bug 27640 at the same time as this bug.

*** This bug has been marked as a duplicate of bug 27640 ***