V8Proxy::retrieveFrameFor*Context are used only by BindingState and should be removed as separate functions
Created attachment 156210 [details] Patch
I'm using retrieveFrameForCallingContext in a patch I'm working on. What should I be using after this?
> I'm using retrieveFrameForCallingContext in a patch I'm working on. What should I be using after this? Bug 93038 has a bunch of examples of removing calls to retrieveFrameForCallingContext. The longer answer is that almost all callers of this function are wrong. This series of patches will result in very few places in the bindings operating in terms of Frames. Almost every instance of the type "Frame" in the bindings is wrong.
I have a case where I need to use the calling ScriptExecutionContext for someWindow.focus(). It is needed to determine if focus should be allowed.
That's a prototypical example. You want activeScriptExecutionContext(BindingState*), which doesn't yet exist but will when I'm done. Almost everyone wants the activeScriptExecutionContext rather than anything having to do with a Frame.
(In reply to comment #5) > That's a prototypical example. You want activeScriptExecutionContext(BindingState*), which doesn't yet exist but will when I'm done. Almost everyone wants the activeScriptExecutionContext rather than anything having to do with a Frame. Sounds good.
Comment on attachment 156210 [details] Patch LGTM.
Comment on attachment 156210 [details] Patch Clearing flags on attachment: 156210 Committed r124563: <http://trac.webkit.org/changeset/124563>
All reviewed patches have been landed. Closing bug.