RESOLVED WONTFIX 93598
[V8] Change v8Undefined() to v8Undefined(Isolate* isolate=0) 
https://bugs.webkit.org/show_bug.cgi?id=93598
Summary [V8] Change v8Undefined() to v8Undefined(Isolate* isolate=0)
Kentaro Hara
Reported 2012-08-09 01:51:25 PDT
Per the discussion in bug 93218, we decided to use v8Undefined(Isolate* isolate=0) instead of v8Undefined(). In follow-up patches, I'll replace all v8Undefined() in V8 binding.
Attachments
Patch (2.07 KB, patch)
2012-08-09 01:58 PDT, Kentaro Hara 		webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from gce-cr-linux-07 (462.11 KB, application/zip)
2012-08-09 05:25 PDT, WebKit Review Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-08-09 01:58:32 PDT
Created attachment 157427 [details] Patch
WebKit Review Bot
Comment 2 2012-08-09 05:25:40 PDT
Comment on attachment 157427 [details] Patch Attachment 157427 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13458655 New failing tests: http/tests/appcache/different-origin-manifest.html compositing/checkerboard.html animations/3d/matrix-transform-type-animation.html canvas/philip/tests/2d.pattern.animated.gif.html animations/3d/state-at-end-event-transform.html animations/animation-add-events-in-handler.html http/tests/appcache/deferred-events-delete-while-raising.html animations/additive-transform-animations.html animations/3d/replace-filling-transform.html http/tests/appcache/deferred-events-delete-while-raising-timer.html http/tests/appcache/crash-when-navigating-away-then-back.html accessibility/loading-iframe-sends-notification.html animations/animation-border-overflow.html animations/animation-direction-alternate-reverse.html animations/animation-controller-drt-api.html IDBKeyFromValueAndKeyPathTest.TopLevelPropertyStringValue animations/3d/change-transform-in-end-event.html accessibility/loading-iframe-updates-axtree.html http/tests/appcache/destroyed-frame.html compositing/absolute-position-changed-with-composited-parent-layer.html compositing/absolute-position-changed-in-composited-layer.html WebFrameTest.DispatchMessageEventWithOriginCheck canvas/philip/tests/2d.drawImage.animated.apng.html animations/3d/transform-perspective.html IDBKeyFromValueAndKeyPathTest.TopLevelPropertyNumberValue accessibility/textbox-role-on-contenteditable-crash.html http/tests/appcache/cyrillic-uri.html animations/3d/transform-origin-vs-functions.html accessibility/notification-listeners.html IDBKeyFromValueAndKeyPathTest.SubProperty canvas/philip/tests/2d.drawImage.animated.gif.html animations/animation-direction-reverse-fill-mode-hardware.html accessibility/menu-list-sends-change-notification.html accessibility/multiselect-list-reports-active-option.html
WebKit Review Bot
Comment 3 2012-08-09 05:25:45 PDT
Created attachment 157445 [details] Archive of layout-test-results from gce-cr-linux-07 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: gce-cr-linux-07 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Kentaro Hara
Comment 4 2012-08-09 05:42:45 PDT
Comment on attachment 157427 [details] Patch Looks like more investigation is required. In short: - v8::Handle<v8::Value>() and v8::Undefined() are not equivalent, as I mentioned before. There are some places where we must use v8::Undefined() instead of v8::Handle<v8::Value>(). - I've thought that there would be no place where we must use v8::Handle<v8::Value>() instead of v8::Undefined(). But this assumption was wrong, which caused the test failures. After organizing my thoughts, let me post a patch again.
Kentaro Hara
Comment 5 2012-12-04 21:51:40 PST
See this comment: https://bugs.webkit.org/show_bug.cgi?id=93218#c17
Note You need to log in before you can comment on or make changes to this bug.