Bug 93217 - [V8] Replace v8::Undefined() in custom bindings with v8Undefined()
Summary: [V8] Replace v8::Undefined() in custom bindings with v8Undefined()
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks: 93095
  Show dependency tree / graph
 
Reported: 2012-08-05 18:33 PDT by Kentaro Hara
Modified: 2012-08-09 01:48 PDT (History)
3 users (show)

See Also:

Attachments
Patch (63.04 KB, patch)
2012-08-05 18:34 PDT, Kentaro Hara 		webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
patch for landing (63.07 KB, patch)
2012-08-07 17:56 PDT, Kentaro Hara 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-08-05 18:33:38 PDT 
We should use v8Undefined() everywhere in V8 bindings.
Comment 1 Kentaro Hara 2012-08-05 18:34:56 PDT 
Created attachment 156581 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-08-07 15:22:07 PDT 
Comment on attachment 156581 [details]
Patch

OK.  LGTM.
Comment 3 WebKit Review Bot 2012-08-07 16:01:31 PDT 
Comment on attachment 156581 [details]
Patch

Rejecting attachment 156581 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
v8/custom/V8WebGLRenderingContextCustom.cpp
patching file Source/WebCore/bindings/v8/custom/V8WorkerContextCustom.cpp
patching file Source/WebCore/bindings/v8/custom/V8WorkerCustom.cpp
patching file Source/WebCore/bindings/v8/custom/V8XMLHttpRequestCustom.cpp
patching file Source/WebCore/bindings/v8/custom/V8XSLTProcessorCustom.cpp

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Eric Seidel']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/13446868
Comment 4 Kentaro Hara 2012-08-07 17:56:40 PDT 
Created attachment 157062 [details]
patch for landing
Comment 5 Kentaro Hara 2012-08-07 17:57:45 PDT 
Let me wait for landing the patch until we complete the discussion in bug 93218.
Comment 6 Kentaro Hara 2012-08-09 01:47:59 PDT 
(In reply to comment #5)
> Let me wait for landing the patch until we complete the discussion in bug 93218.

Per discussion in bug 93218, we decided to use v8Undefined(Isolate* isolate=0) instead of v8Undefined(). Marking WONTFIX.