Bug 93318 – [V8] Rename V8Helpers to V8BindingHelpers

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore JavaScript

[Kentaro Hara]

For naming consistency, a file including binding utility methods should be prefixed by "V8Binding". In a follow-up patch, I'll move methods from V8Binding to V8BindingHelpers.

[Kentaro Hara]

Created attachment 156822 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 156822 [details]
Patch

rs=me.

[WebKit Review Bot]

Comment on attachment 156822 [details]
Patch

Rejecting attachment 156822 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
Kit/chromium/third_party/yasm/source/patched-yasm --revision 134927 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
47>At revision 134927.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/13459004

[Kentaro Hara]

Created attachment 157051 [details]
patch for landing

[WebKit Review Bot]

Comment on attachment 157051 [details]
patch for landing

Rejecting attachment 157051 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
Kit/chromium/third_party/yasm/source/patched-yasm --revision 134927 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
49>At revision 134927.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/13451646

[Kentaro Hara]

Created attachment 157166 [details]
patch for landing

[WebKit Review Bot]

Comment on attachment 157166 [details]
patch for landing

Rejecting attachment 157166 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
le Source/WebCore/bindings/v8/V8BindingHelpers.cpp
patching file Source/WebCore/bindings/v8/V8BindingHelpers.h
patching file Source/WebCore/bindings/v8/V8Helpers.cpp
rm 'Source/WebCore/bindings/v8/V8Helpers.cpp'
patching file Source/WebCore/bindings/v8/V8Helpers.h
rm 'Source/WebCore/bindings/v8/V8Helpers.h'
patching file Source/WebCore/bindings/v8/V8NPObject.cpp

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/13448929

[Kentaro Hara]

Created attachment 157167 [details]
patch for landing

[WebKit Review Bot]

Comment on attachment 157167 [details]
patch for landing

Clearing flags on attachment: 157167

Committed r125020: <http://trac.webkit.org/changeset/125020>