Bug 93595 - [V8] Rename V8BindingPerContextData to V8PerContextData
Summary: [V8] Rename V8BindingPerContextData to V8PerContextData
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks: 93095
  Show dependency treegraph
 
Reported: 2012-08-09 01:33 PDT by Kentaro Hara
Modified: 2012-08-09 20:06 PDT (History)
5 users (show)

See Also:


Attachments
Patch (33.82 KB, patch)
2012-08-09 01:40 PDT, Kentaro Hara
no flags Details | Formatted Diff | Diff
patch for landing (33.80 KB, patch)
2012-08-09 16:44 PDT, Kentaro Hara
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
patch for landing (33.93 KB, patch)
2012-08-09 18:01 PDT, Kentaro Hara
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-08-09 01:33:14 PDT
For a better name. See discussion in bug 93333.
Comment 1 Kentaro Hara 2012-08-09 01:40:18 PDT
Created attachment 157423 [details]
Patch
Comment 2 Adam Barth 2012-08-09 09:45:16 PDT
Comment on attachment 157423 [details]
Patch

The bug title was slightly off.  You might want to update the ChangeLog before landing.
Comment 3 Kentaro Hara 2012-08-09 16:44:06 PDT
Created attachment 157578 [details]
patch for landing
Comment 4 WebKit Review Bot 2012-08-09 17:55:11 PDT
Comment on attachment 157578 [details]
patch for landing

Rejecting attachment 157578 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
ing file Source/WebCore/bindings/v8/V8PerContextData.cpp
patching file Source/WebCore/bindings/v8/V8PerContextData.h
patching file Source/WebCore/bindings/v8/V8Proxy.cpp
patching file Source/WebCore/bindings/v8/V8Proxy.h
patching file Source/WebCore/bindings/v8/WorkerContextExecutionProxy.cpp
patching file Source/WebCore/bindings/v8/WorkerContextExecutionProxy.h

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/13461700
Comment 5 Kentaro Hara 2012-08-09 18:01:23 PDT
Created attachment 157599 [details]
patch for landing
Comment 6 WebKit Review Bot 2012-08-09 20:05:25 PDT
Comment on attachment 157599 [details]
patch for landing

Clearing flags on attachment: 157599

Committed r125242: <http://trac.webkit.org/changeset/125242>