Bug 93333 – [V8] Factor out V8BindingPerIsolateData from V8Binding to a separate file

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore JavaScript

[Kentaro Hara]

We can move V8BindingPerIsolateData to V8BindingPerIsolateData.{h,cpp}.

I'll rename V8BindingPerIsolateData to V8PerIsolateData in a follow-up patch.

[Kentaro Hara]

Created attachment 156856 [details]
Patch

[WebKit Review Bot]

Comment on attachment 156856 [details]
Patch

Attachment 156856 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13447709

[Kentaro Hara]

Created attachment 156857 [details]
Patch

[Adam Barth]

Comment on attachment 156857 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=156857&action=review

> Source/WebCore/bindings/v8/V8Binding.h:40
> +#include "V8BindingPerIsolateData.h"

Should we just call this V8PerIsolateData ?

[Kentaro Hara]

(In reply to comment #4)
> > Source/WebCore/bindings/v8/V8Binding.h:40
> > +#include "V8BindingPerIsolateData.h"
> 
> Should we just call this V8PerIsolateData ?

Yes, I'll rename V8BindingPerIsolateData to V8PerIsolateData, and rename V8BindingPerContextData to V8PerContextData, in a follow-up patch.

[WebKit Review Bot]

Comment on attachment 156857 [details]
Patch

Rejecting attachment 156857 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
 #1 FAILED at 37.
Hunk #2 succeeded at 68 (offset -68 lines).
Hunk #3 succeeded at 82 (offset -68 lines).
1 out of 3 hunks FAILED -- saving rejects to file Source/WebCore/bindings/v8/V8Binding.h.rej
patching file Source/WebCore/bindings/v8/V8BindingPerIsolateData.cpp
patching file Source/WebCore/bindings/v8/V8BindingPerIsolateData.h

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Adam Barth']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/13449637

[Kentaro Hara]

Created attachment 157074 [details]
patch for landing

[WebKit Review Bot]

Comment on attachment 157074 [details]
patch for landing

Rejecting attachment 157074 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
n "['Tools/Scripts/build-webkit', '--debug', '--chromium', '--update-chromium']" exit_code: 2
get/webcore_dom/Source/WebCore/dom/MessagePort.o] Error 1
make: *** Waiting for unfinished jobs....
make: *** [out/Debug/obj.target/webcore_dom/Source/WebCore/dom/ActiveDOMObject.o] Error 1
make: *** [out/Debug/obj.target/webcore_remaining/Source/WebCore/Modules/filesystem/WorkerContextFileSystem.o] Error 1
make: *** [out/Debug/obj.target/webcore_dom/Source/WebCore/dom/ScriptExecutionContext.o] Error 1

Full output: http://queues.webkit.org/results/13459085

[Adam Barth]

Sorry for all the naming nits.  The patches themselves are great, which makes my mind wander to how to improve the code further.

[Kentaro Hara]

Created attachment 157127 [details]
patch for landing

[WebKit Review Bot]

Comment on attachment 157127 [details]
patch for landing

Clearing flags on attachment: 157127

Committed r125015: <http://trac.webkit.org/changeset/125015>