Bug 93220 - [V8] Replace all V8 undefined values in the rest of V8 bindings with v8Undefined()
Summary: [V8] Replace all V8 undefined values in the rest of V8 bindings with v8Undefi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks: 93095
  Show dependency tree / graph
 
Reported: 2012-08-05 19:15 PDT by Kentaro Hara
Modified: 2012-08-07 16:32 PDT (History)
3 users (show)

See Also:

Attachments
Patch (5.00 KB, patch)
2012-08-05 19:18 PDT, Kentaro Hara 		no flags Details | Formatted Diff | Diff
Patch (5.87 KB, patch)
2012-08-05 19:51 PDT, Kentaro Hara 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-08-05 19:15:25 PDT 
We should use v8Undefined() everywhere in V8 bindings.

In this bug, we replace all V8 undefined values in the rest of custom bindings with v8Undefined().
Comment 1 Kentaro Hara 2012-08-05 19:18:52 PDT 
Created attachment 156585 [details]
Patch
Comment 2 Kentaro Hara 2012-08-05 19:51:15 PDT 
Created attachment 156586 [details]
Patch
Comment 3 Eric Seidel (no email) 2012-08-07 15:21:33 PDT 
Comment on attachment 156586 [details]
Patch

LGTM.
Comment 4 WebKit Review Bot 2012-08-07 16:32:06 PDT 
Comment on attachment 156586 [details]
Patch

Clearing flags on attachment: 156586

Committed r124938: <http://trac.webkit.org/changeset/124938>
Comment 5 WebKit Review Bot 2012-08-07 16:32:10 PDT 
All reviewed patches have been landed.  Closing bug.