Bug 94710 - [V8] Remove template of V8DOMConfiguration::configureAttribute()
Summary: [V8] Remove template of V8DOMConfiguration::configureAttribute()
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks: 93095
  Show dependency tree / graph
 
Reported: 2012-08-22 07:42 PDT by Kentaro Hara
Modified: 2012-08-22 07:47 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-08-22 07:42:07 PDT 
template<T> is not needed for V8DOMConfiguration::configureAttribute(). We can remove the template and de-inline the method. Given that SetAccessor() does a bunch of complicated stuff, de-inlining V8DOMConfiguration::configureAttribute() would make sense.
Comment 1 Kentaro Hara 2012-08-22 07:47:50 PDT 
Sorry, I was confused. Please ignore this bug.

configureAttribute() can be called for both ObjectTemplate and Object, so it needs to be implemented by template<T>, where T is ObjectTemplate or Object.