Bug 93211 - [V8] Replace v8::Handle<v8::Value>() in bindings/v8/* with v8Undefined()
Summary: [V8] Replace v8::Handle<v8::Value>() in bindings/v8/* with v8Undefined()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks: 93095
  Show dependency treegraph
 
Reported: 2012-08-05 17:19 PDT by Kentaro Hara
Modified: 2012-08-07 21:44 PDT (History)
3 users (show)

See Also:


Attachments
Patch (45.16 KB, patch)
2012-08-05 17:21 PDT, Kentaro Hara
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
patch for landing (45.76 KB, patch)
2012-08-07 17:35 PDT, Kentaro Hara
haraken: commit-queue-
Details | Formatted Diff | Diff
patch for landing (11.20 KB, patch)
2012-08-07 17:47 PDT, Kentaro Hara
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-08-05 17:19:06 PDT
We should use v8Undefined() everywhere in V8 bindings.

Replacing v8::Local<v8::Value>() etc with v8Undefined() can cause build errors due to type conversion mismatch. I'll do the replacement in follow-up patches.
Comment 1 Kentaro Hara 2012-08-05 17:21:03 PDT
Created attachment 156576 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-08-07 15:22:51 PDT
Comment on attachment 156576 [details]
Patch

LGTM.
Comment 3 WebKit Review Bot 2012-08-07 15:59:26 PDT
Comment on attachment 156576 [details]
Patch

Rejecting attachment 156576 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
WebCore/bindings/v8/custom/V8NamedNodeMapCustom.cpp
patching file Source/WebCore/bindings/v8/custom/V8NodeListCustom.cpp
patching file Source/WebCore/bindings/v8/custom/V8SVGLengthCustom.cpp
patching file Source/WebCore/bindings/v8/custom/V8StorageCustom.cpp
patching file Source/WebCore/bindings/v8/custom/V8StyleSheetListCustom.cpp

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Eric Seidel']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/13448745
Comment 4 Kentaro Hara 2012-08-07 17:35:48 PDT
Created attachment 157055 [details]
patch for landing
Comment 5 Kentaro Hara 2012-08-07 17:47:10 PDT
Created attachment 157058 [details]
patch for landing
Comment 6 WebKit Review Bot 2012-08-07 21:38:35 PDT
Comment on attachment 157058 [details]
patch for landing

Clearing flags on attachment: 157058

Committed r124981: <http://trac.webkit.org/changeset/124981>