[V8] Remove unused methods from V8Binding.h

[Kentaro Hara]

enableStringImplCache() and v8UndetectableString() are not used by anybody.

[Kentaro Hara]

Created attachment 157980 [details]
Patch

[Adam Barth]

Comment on attachment 157980 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=157980&action=review

> Source/WebCore/bindings/v8/V8Binding.h:-398
> -    inline v8::Handle<v8::String> v8UndetectableString(const String& str)
> -    {
> -        return v8::String::NewUndetectable(fromWebCoreString(str), str.length());
> -    }

I'm surprised this isn't used by document.all.  Maybe that uses another mechanism now?

[Kentaro Hara]

Committed r125492: <http://trac.webkit.org/changeset/125492>

[Kentaro Hara]

Comment on attachment 157980 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=157980&action=review

>> Source/WebCore/bindings/v8/V8Binding.h:-398
>> -    }
> 
> I'm surprised this isn't used by document.all.  Maybe that uses another mechanism now?

It's realized by forcibly setting properties on 'this' object. (i.e. info.This()->ForceSet(name, value))

http://code.google.com/codesearch#OAMlx_jo-ck/src/third_party/WebKit/Source/WebCore/bindings/v8/custom/V8HTMLDocumentCustom.cpp&exact_package=chromium&q=v8htmldocumentcustom.cpp&type=cs&l=184