RESOLVED FIXED 93836
[V8] Remove unused methods from V8Binding.h 
https://bugs.webkit.org/show_bug.cgi?id=93836
Summary [V8] Remove unused methods from V8Binding.h
Kentaro Hara
Reported 2012-08-13 06:31:10 PDT
enableStringImplCache() and v8UndetectableString() are not used by anybody.
Attachments
Patch (2.08 KB, patch)
2012-08-13 06:32 PDT, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-08-13 06:32:07 PDT
Created attachment 157980 [details] Patch
Adam Barth
Comment 2 2012-08-13 10:40:52 PDT
Comment on attachment 157980 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=157980&action=review > Source/WebCore/bindings/v8/V8Binding.h:-398 > - inline v8::Handle<v8::String> v8UndetectableString(const String& str) > - { > - return v8::String::NewUndetectable(fromWebCoreString(str), str.length()); > - } I'm surprised this isn't used by document.all. Maybe that uses another mechanism now?
Kentaro Hara
Comment 3 2012-08-13 18:35:13 PDT
Committed r125492: <http://trac.webkit.org/changeset/125492>
Kentaro Hara
Comment 4 2012-08-13 18:35:51 PDT
Comment on attachment 157980 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=157980&action=review >> Source/WebCore/bindings/v8/V8Binding.h:-398 >> - } > > I'm surprised this isn't used by document.all. Maybe that uses another mechanism now? It's realized by forcibly setting properties on 'this' object. (i.e. info.This()->ForceSet(name, value)) http://code.google.com/codesearch#OAMlx_jo-ck/src/third_party/WebKit/Source/WebCore/bindings/v8/custom/V8HTMLDocumentCustom.cpp&exact_package=chromium&q=v8htmldocumentcustom.cpp&type=cs&l=184
Note You need to log in before you can comment on or make changes to this bug.