Bug 93215 - [V8] Replace v8::Handle<v8::Value>() in custom bindings with v8Undefined()
Summary: [V8] Replace v8::Handle<v8::Value>() in custom bindings with v8Undefined()
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
Depends on:
Blocks: 93095
  Show dependency treegraph
Reported: 2012-08-05 18:22 PDT by Kentaro Hara
Modified: 2012-08-07 22:04 PDT (History)
3 users (show)

See Also:

Patch (34.85 KB, patch)
2012-08-05 18:24 PDT, Kentaro Hara
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
patch for landing (34.92 KB, patch)
2012-08-07 17:39 PDT, Kentaro Hara
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-08-05 18:22:43 PDT
We should use v8Undefined() everywhere in V8 bindings.
Comment 1 Kentaro Hara 2012-08-05 18:24:08 PDT
Created attachment 156580 [details]
Comment 2 Eric Seidel (no email) 2012-08-07 15:22:27 PDT
Comment on attachment 156580 [details]

Comment 3 WebKit Review Bot 2012-08-07 16:00:28 PDT
Comment on attachment 156580 [details]

Rejecting attachment 156580 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
patching file Source/WebCore/bindings/v8/custom/V8NodeListCustom.cpp
patching file Source/WebCore/bindings/v8/custom/V8SVGLengthCustom.cpp
patching file Source/WebCore/bindings/v8/custom/V8StorageCustom.cpp
patching file Source/WebCore/bindings/v8/custom/V8StyleSheetListCustom.cpp

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Eric Seidel']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/13449601
Comment 4 Kentaro Hara 2012-08-07 17:39:26 PDT
Created attachment 157056 [details]
patch for landing
Comment 5 WebKit Review Bot 2012-08-07 22:02:53 PDT
Comment on attachment 157056 [details]
patch for landing

Clearing flags on attachment: 157056

Committed r124984: <http://trac.webkit.org/changeset/124984>