Bug 93334 – [V8] Move setIsolatedWorldSecurityOrigin() from V8Proxy to ScriptController

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore JavaScript

[Kentaro Hara]

The goal is to move m_isolatedWorlds, m_isolatedWorldSecurityOrigins and related methods from V8Proxy to ScriptController. As a starting point, in this bug we move setIsolatedWorldSecurityOrigin().

[Kentaro Hara]

Created attachment 156861 [details]
Patch

[Adam Barth]

Comment on attachment 156861 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=156861&action=review

> Source/WebCore/bindings/v8/ScriptController.cpp:183
>  void ScriptController::setIsolatedWorldSecurityOrigin(int worldID, PassRefPtr<SecurityOrigin> securityOrigin)

A better name for this function is something like setSecurityOriginForIsolatedWorld, but don't feel like you need to go renaming crazy in this patch.

[Kentaro Hara]

(In reply to comment #2)
> A better name for this function is something like setSecurityOriginForIsolatedWorld, but don't feel like you need to go renaming crazy in this patch.

This method is exposed to the Chromium WebKit API. If we want to rename it, we should rename the API name too. If you want, I'll do it. WDYT?

http://code.google.com/codesearch#OAMlx_jo-ck/src/third_party/WebKit/Source/WebKit/chromium/public/WebFrame.h&exact_package=chromium&q=setIsolatedWorldSecurityOrigin&type=cs&l=258

Either way let me land this patch first.

[WebKit Review Bot]

Comment on attachment 156861 [details]
Patch

Clearing flags on attachment: 156861

Committed r124962: <http://trac.webkit.org/changeset/124962>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Adam Barth]

It's probably too much work to rename the API.

[Kentaro Hara]

OK, then let's keep it as is.