Bug 93818 - [V8] Move GCEventData class from V8Binding.h to ScriptGCEvent.h
Summary: [V8] Move GCEventData class from V8Binding.h to ScriptGCEvent.h
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
Depends on:
Blocks: 93095
  Show dependency treegraph
Reported: 2012-08-13 04:05 PDT by Kentaro Hara
Modified: 2012-11-13 16:20 PST (History)
3 users (show)

See Also:

Patch (5.78 KB, patch)
2012-08-13 04:09 PDT, Kentaro Hara
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-08-13 04:05:44 PDT
We can move the GCEventData class from V8Binding.h to ScriptGCEvent.h.
Comment 1 Kentaro Hara 2012-08-13 04:09:00 PDT
Created attachment 157957 [details]
Comment 2 Adam Barth 2012-08-13 10:32:46 PDT
Comment on attachment 157957 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=157957&action=review

> Source/WebCore/bindings/v8/ScriptGCEvent.h:58
> +    GCEventData() : m_startTime(0.0), m_usedHeapSize(0) { }

This should be split onto a bunch of lines.

> Source/WebCore/bindings/v8/ScriptGCEvent.h:63
> +    }

Can you add blank lines between member functions that have multi-line bodies?
Comment 3 Kentaro Hara 2012-08-13 18:46:18 PDT
Committed r125494: <http://trac.webkit.org/changeset/125494>