Bug 93223 - [V8] Replace throwError(ExceptionCode, Isolate*) with setDOMException(ExceptionCode, Isolate*) in CodeGeneratorV8.pm
Summary: [V8] Replace throwError(ExceptionCode, Isolate*) with setDOMException(Excepti...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks: 93095
  Show dependency treegraph
 
Reported: 2012-08-05 21:44 PDT by Kentaro Hara
Modified: 2012-08-07 17:56 PDT (History)
3 users (show)

See Also:


Attachments
Patch (9.14 KB, patch)
2012-08-05 21:55 PDT, Kentaro Hara
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-08-05 21:44:03 PDT
Now throwError(ExceptionCode, Isolate*) is equivalent to setDOMException(ExceptionCode, Isolate*). We can replace the former with the latter. After this replacement, the rule becomes simple and sane: "Use throwError() for throwing JavaScript errors, use setDOMException() for throwing DOM exceptions".
Comment 1 Kentaro Hara 2012-08-05 21:55:20 PDT
Created attachment 156592 [details]
Patch
Comment 2 Kentaro Hara 2012-08-05 23:18:25 PDT
I couldn't replace throwError(ExceptionCode) with setDOMException(ExceptionCode, Isolate*) in V8Utilities::extractTransferables(), because extractTransferables() does not know an Isolate. I will upload follow-up patches to pass an Isolate to Dictionary, and then to extractTransferables().
Comment 3 Kentaro Hara 2012-08-05 23:19:47 PDT
(In reply to comment #2)
> I couldn't replace throwError(ExceptionCode) with setDOMException(ExceptionCode, Isolate*) in V8Utilities::extractTransferables(), because extractTransferables() does not know an Isolate. I will upload follow-up patches to pass an Isolate to Dictionary, and then to extractTransferables().

Nit: the above comment should have been posted to bug 93226.
Comment 4 Adam Barth 2012-08-07 17:03:00 PDT
Comment on attachment 156592 [details]
Patch

ok
Comment 5 WebKit Review Bot 2012-08-07 17:56:45 PDT
Comment on attachment 156592 [details]
Patch

Clearing flags on attachment: 156592

Committed r124955: <http://trac.webkit.org/changeset/124955>
Comment 6 WebKit Review Bot 2012-08-07 17:56:48 PDT
All reviewed patches have been landed.  Closing bug.