Bug 93239 - [V8] Factor out V8Binding methods about configuring DOM attributes and methods
Summary: [V8] Factor out V8Binding methods about configuring DOM attributes and methods
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks: 93095
  Show dependency tree / graph
 
Reported: 2012-08-06 02:27 PDT by Kentaro Hara
Modified: 2012-08-07 16:38 PDT (History)
5 users (show)

See Also:

Attachments
Patch (20.22 KB, patch)
2012-08-06 02:31 PDT, Kentaro Hara 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-08-06 02:27:49 PDT 
V8Binding is messy. We can factor out V8Binding methods about configuring DOM attributes and methods into another file.
Comment 1 Kentaro Hara 2012-08-06 02:31:08 PDT 
Created attachment 156635 [details]
Patch
Comment 2 Adam Barth 2012-08-07 15:22:49 PDT 
Comment on attachment 156635 [details]
Patch

I would take this opportunity to change these files into WebKit style (e.g., not 80 column).

Consider turning these functions into static functions in a class:

V8DOMConfiguration::batchConfigureAttributes(...)

You don't have to do these things, but it's nice to clean up this stuff as we touch it.
Comment 3 Kentaro Hara 2012-08-07 15:23:45 PDT 
Comment on attachment 156635 [details]
Patch

Sounds nice. I'll fix it in a follow-up patch.
Comment 4 WebKit Review Bot 2012-08-07 16:38:41 PDT 
Comment on attachment 156635 [details]
Patch

Clearing flags on attachment: 156635

Committed r124940: <http://trac.webkit.org/changeset/124940>
Comment 5 WebKit Review Bot 2012-08-07 16:38:47 PDT 
All reviewed patches have been landed.  Closing bug.