NEW 58412
Flaky Test: http/tests/misc/favicon-loads-with-icon-loading-override.html
https://bugs.webkit.org/show_bug.cgi?id=58412
Summary Flaky Test: http/tests/misc/favicon-loads-with-icon-loading-override.html
WebKit Commit Bot
Reported 2011-04-12 21:47:33 PDT
This is an automatically generated bug from the commit-queue. http/tests/misc/favicon-loads-with-icon-loading-override.html has been flaky on the commit-queue. http/tests/misc/favicon-loads-with-icon-loading-override.html was authored by alice.liu@apple.com. http://trac.webkit.org/browser/trunk/LayoutTests/http/tests/misc/favicon-loads-with-icon-loading-override.html The commit-queue just saw http/tests/misc/favicon-loads-with-icon-loading-override.html flake (Text diff mismatch) while processing attachment 89326 [details] on bug 58409. Bot: eseidel-cq-sf Port: Mac Platform: Mac OS X 10.6.4 The bots will update this with information from each new failure. If you believe this bug to be fixed or invalid, feel free to close. The bots will re-open if the flake re-occurs. If you would like to track this test fix with another bug, please close this bug as a duplicate. The bots will follow the duplicate chain when making future comments.
Attachments
Failure diff from eseidel-cq-sf (1.63 KB, text/plain)
2011-04-12 21:47 PDT, WebKit Commit Bot
no flags
Failure diff from eseidel-cq-sf (1.63 KB, text/plain)
2011-04-13 22:37 PDT, WebKit Commit Bot
no flags
Failure diff from eseidel-cq-sf (1.63 KB, text/plain)
2011-04-14 00:09 PDT, WebKit Commit Bot
no flags
Failure diff from eseidel-cq-sf (1.63 KB, text/plain)
2011-04-14 02:36 PDT, WebKit Commit Bot
no flags
Failure diff from eseidel-cq-sf (1.63 KB, text/plain)
2011-04-14 04:38 PDT, WebKit Commit Bot
no flags
Failure diff from eseidel-cq-sf (1.63 KB, text/plain)
2011-04-14 06:19 PDT, WebKit Commit Bot
no flags
Failure diff from eseidel-cq-sf (1.63 KB, text/plain)
2011-04-14 19:06 PDT, WebKit Commit Bot
no flags
Failure diff from eseidel-cq-sf (1.63 KB, text/plain)
2011-04-14 21:27 PDT, WebKit Commit Bot
no flags
Failure diff from eseidel-cq-sf (1.63 KB, text/plain)
2011-04-15 00:10 PDT, WebKit Commit Bot
no flags
Failure diff from eseidel-cq-sf (1.63 KB, text/plain)
2011-04-15 01:07 PDT, WebKit Commit Bot
no flags
Failure diff from eseidel-cq-sf (1.63 KB, text/plain)
2011-04-15 09:17 PDT, WebKit Commit Bot
no flags
Failure diff from eseidel-cq-sf (1.63 KB, text/plain)
2011-04-15 16:32 PDT, WebKit Commit Bot
no flags
Failure diff from eseidel-cq-sf (1.63 KB, text/plain)
2011-04-17 11:57 PDT, WebKit Commit Bot
no flags
Failure diff from eseidel-cq-sf (1.63 KB, text/plain)
2011-04-18 20:08 PDT, WebKit Commit Bot
no flags
Failure diff from cr-jail-7 (1.63 KB, text/plain)
2011-04-18 21:25 PDT, WebKit Commit Bot
no flags
Failure diff from eseidel-cq-sf (1.63 KB, text/plain)
2011-04-18 22:05 PDT, WebKit Commit Bot
no flags
Failure diff from eseidel-cq-sf (1.63 KB, text/plain)
2011-04-19 12:20 PDT, WebKit Commit Bot
no flags
Failure diff from cr-jail-7 (1.63 KB, text/plain)
2011-04-19 20:32 PDT, WebKit Commit Bot
no flags
Failure diff from eseidel-cq-sf (1.63 KB, text/plain)
2011-04-20 21:10 PDT, WebKit Commit Bot
no flags
Failure diff from eseidel-cq-sf (1.63 KB, text/plain)
2011-04-20 22:56 PDT, WebKit Commit Bot
no flags
Failure diff from eseidel-cq-sf (1.63 KB, text/plain)
2011-04-21 00:41 PDT, WebKit Commit Bot
no flags
Failure diff from cr-jail-7 (1.63 KB, text/plain)
2011-04-21 08:18 PDT, WebKit Commit Bot
no flags
Failure diff from eseidel-cq-sf (1.63 KB, text/plain)
2011-04-21 08:55 PDT, WebKit Commit Bot
no flags
Failure diff from eseidel-cq-sf (1.63 KB, text/plain)
2011-04-21 12:06 PDT, WebKit Commit Bot
no flags
Failure diff from eseidel-cq-sf (1.63 KB, text/plain)
2011-04-21 14:19 PDT, WebKit Commit Bot
no flags
Failure diff from eseidel-cq-sf (1.63 KB, text/plain)
2011-04-22 11:48 PDT, WebKit Commit Bot
no flags
Failure diff from eseidel-cq-sf (1.63 KB, text/plain)
2011-04-22 14:18 PDT, WebKit Commit Bot
no flags
Failure diff from eseidel-cq-sf (1.63 KB, text/plain)
2011-04-24 02:14 PDT, WebKit Commit Bot
no flags
Failure diff from eseidel-cq-sf (1.63 KB, text/plain)
2011-04-26 07:38 PDT, WebKit Commit Bot
no flags
Failure diff from cr-jail-7 (1.63 KB, text/plain)
2011-04-28 05:57 PDT, WebKit Commit Bot
no flags
Failure diff from eseidel-cq-sf (1.63 KB, text/plain)
2011-05-04 19:32 PDT, WebKit Commit Bot
no flags
Failure diff from cr-jail-8 (1.63 KB, text/plain)
2011-05-06 00:46 PDT, WebKit Commit Bot
no flags
Failure diff from eseidel-cq-sf (1.63 KB, text/plain)
2011-05-07 07:33 PDT, WebKit Commit Bot
no flags
Failure diff from eseidel-cq-sf (1.63 KB, text/plain)
2011-05-07 22:17 PDT, WebKit Commit Bot
no flags
Failure diff from eseidel-cq-sf (1.63 KB, text/plain)
2011-05-08 11:50 PDT, WebKit Commit Bot
no flags
Failure diff from eseidel-cq-sf (1.63 KB, text/plain)
2011-05-08 23:33 PDT, WebKit Commit Bot
no flags
Failure diff from eseidel-cq-sf (1.63 KB, text/plain)
2011-05-09 07:59 PDT, WebKit Commit Bot
no flags
Failure diff from eseidel-cq-sf (1.63 KB, text/plain)
2011-05-09 14:05 PDT, WebKit Commit Bot
no flags
Failure diff from eseidel-cq-sf (1.63 KB, text/plain)
2011-05-09 18:52 PDT, WebKit Commit Bot
no flags
Failure diff from eseidel-cq-sf (1.63 KB, text/plain)
2011-05-10 10:44 PDT, WebKit Commit Bot
no flags
Failure diff from eseidel-cq-sf (1.63 KB, text/plain)
2011-05-10 18:41 PDT, WebKit Commit Bot
no flags
Failure diff from eseidel-cq-sf (1.63 KB, text/plain)
2011-05-11 09:54 PDT, WebKit Commit Bot
no flags
Failure diff from eseidel-cq-sf (1.63 KB, text/plain)
2011-05-11 12:09 PDT, WebKit Commit Bot
no flags
Failure diff from eseidel-cq-sf (1.63 KB, text/plain)
2011-05-11 13:38 PDT, WebKit Commit Bot
no flags
Failure diff from eseidel-cq-sf (1.63 KB, text/plain)
2011-05-11 15:47 PDT, WebKit Commit Bot
no flags
Failure diff from eseidel-cq-sf (1.63 KB, text/plain)
2011-05-12 00:40 PDT, WebKit Commit Bot
no flags
Failure diff from eseidel-cq-sf (1.63 KB, text/plain)
2011-05-12 11:24 PDT, WebKit Commit Bot
no flags
Failure diff from eseidel-cq-sf (1.63 KB, text/plain)
2011-05-12 22:22 PDT, WebKit Commit Bot
no flags
Failure diff from eseidel-cq-sf (1.63 KB, text/plain)
2011-05-16 10:28 PDT, WebKit Commit Bot
no flags
Failure diff from eseidel-cq-sf (1.63 KB, text/plain)
2011-05-16 16:28 PDT, WebKit Commit Bot
no flags
Failure diff from eseidel-cq-sf (1.63 KB, text/plain)
2011-05-18 12:33 PDT, WebKit Commit Bot
no flags
Failure diff from eseidel-cq-sf (1.63 KB, text/plain)
2011-05-18 16:35 PDT, WebKit Commit Bot
no flags
Failure diff from eseidel-cq-sf (1.63 KB, text/plain)
2011-05-18 17:14 PDT, WebKit Commit Bot
no flags
Failure diff from eseidel-cq-sf (1.63 KB, text/plain)
2011-05-19 02:31 PDT, WebKit Commit Bot
no flags
Failure diff from cr-jail-4 (1.63 KB, text/plain)
2011-05-23 07:19 PDT, WebKit Commit Bot
no flags
Failure diff from cr-jail-4 (1.63 KB, text/plain)
2011-05-23 21:08 PDT, WebKit Commit Bot
no flags
Failure diff from cr-jail-4 (1.63 KB, text/plain)
2011-05-26 13:08 PDT, WebKit Commit Bot
no flags
Failure diff from cr-jail-8 (1.63 KB, text/plain)
2011-06-01 06:01 PDT, WebKit Commit Bot
no flags
Failure diff from cr-jail-7 (1.63 KB, text/plain)
2011-06-04 06:29 PDT, WebKit Commit Bot
no flags
WebKit Commit Bot
Comment 1 2011-04-12 21:47:35 PDT
Created attachment 89336 [details] Failure diff from eseidel-cq-sf
Alice Liu
Comment 2 2011-04-12 21:50:53 PDT
On what platform is this bot running?
Alice Liu
Comment 3 2011-04-12 21:53:06 PDT
oh, i see 10.6.4 mac. this test hasn't been flakey on the core snowleopard bots.
Eric Seidel (no email)
Comment 4 2011-04-13 06:21:57 PDT
Given that this is the first time we've seen it flake, it's likely a very new (or very rare) flake.
Eric Seidel (no email)
Comment 5 2011-04-13 06:22:49 PDT
I wouldn't worry about it unless we see it happen again.
Eric Seidel (no email)
Comment 6 2011-04-13 06:23:27 PDT
The flake (as you can tell from the attachment diff) was caused by the loader callbacks not showing up for some reason. It's possible they bled into a later test or something.
WebKit Commit Bot
Comment 7 2011-04-13 22:37:37 PDT
The commit-queue just saw http/tests/misc/favicon-loads-with-icon-loading-override.html flake (Text diff mismatch) while processing attachment 89425 [details] on bug 58284. Bot: eseidel-cq-sf Port: Mac Platform: Mac OS X 10.6.4
WebKit Commit Bot
Comment 8 2011-04-13 22:37:39 PDT
Created attachment 89535 [details] Failure diff from eseidel-cq-sf
WebKit Commit Bot
Comment 9 2011-04-14 00:09:14 PDT
The commit-queue just saw http/tests/misc/favicon-loads-with-icon-loading-override.html flake (Text diff mismatch) while processing attachment 89415 [details] on bug 58460. Bot: eseidel-cq-sf Port: Mac Platform: Mac OS X 10.6.4
WebKit Commit Bot
Comment 10 2011-04-14 00:09:16 PDT
Created attachment 89541 [details] Failure diff from eseidel-cq-sf
WebKit Commit Bot
Comment 11 2011-04-14 02:36:33 PDT
The commit-queue just saw http/tests/misc/favicon-loads-with-icon-loading-override.html flake (Text diff mismatch) while processing attachment 89451 [details] on bug 58475. Bot: eseidel-cq-sf Port: Mac Platform: Mac OS X 10.6.4
WebKit Commit Bot
Comment 12 2011-04-14 02:36:36 PDT
Created attachment 89551 [details] Failure diff from eseidel-cq-sf
WebKit Commit Bot
Comment 13 2011-04-14 04:38:42 PDT
The commit-queue just saw http/tests/misc/favicon-loads-with-icon-loading-override.html flake (Text diff mismatch) while processing attachment 89229 [details] on bug 58188. Bot: eseidel-cq-sf Port: Mac Platform: Mac OS X 10.6.4
WebKit Commit Bot
Comment 14 2011-04-14 04:38:44 PDT
Created attachment 89554 [details] Failure diff from eseidel-cq-sf
WebKit Commit Bot
Comment 15 2011-04-14 06:19:47 PDT
The commit-queue just saw http/tests/misc/favicon-loads-with-icon-loading-override.html flake (Text diff mismatch) while processing attachment 89458 [details] on bug 58477. Bot: eseidel-cq-sf Port: Mac Platform: Mac OS X 10.6.4
WebKit Commit Bot
Comment 16 2011-04-14 06:19:49 PDT
Created attachment 89572 [details] Failure diff from eseidel-cq-sf
WebKit Commit Bot
Comment 17 2011-04-14 19:06:01 PDT
The commit-queue just saw http/tests/misc/favicon-loads-with-icon-loading-override.html flake (Text diff mismatch) while processing attachment 89518 [details] on bug 57818. Bot: eseidel-cq-sf Port: Mac Platform: Mac OS X 10.6.4
WebKit Commit Bot
Comment 18 2011-04-14 19:06:03 PDT
Created attachment 89719 [details] Failure diff from eseidel-cq-sf
WebKit Commit Bot
Comment 19 2011-04-14 21:27:04 PDT
The commit-queue just saw http/tests/misc/favicon-loads-with-icon-loading-override.html flake (Text diff mismatch) while processing attachment 89558 [details] on bug 58447. Bot: eseidel-cq-sf Port: Mac Platform: Mac OS X 10.6.4
WebKit Commit Bot
Comment 20 2011-04-14 21:27:06 PDT
Created attachment 89732 [details] Failure diff from eseidel-cq-sf
WebKit Commit Bot
Comment 21 2011-04-15 00:10:17 PDT
The commit-queue just saw http/tests/misc/favicon-loads-with-icon-loading-override.html flake (Text diff mismatch) while processing attachment 89621 [details] on bug 53556. Bot: eseidel-cq-sf Port: Mac Platform: Mac OS X 10.6.4
WebKit Commit Bot
Comment 22 2011-04-15 00:10:18 PDT
Created attachment 89747 [details] Failure diff from eseidel-cq-sf
WebKit Commit Bot
Comment 23 2011-04-15 01:07:38 PDT
The commit-queue just saw http/tests/misc/favicon-loads-with-icon-loading-override.html flake (Text diff mismatch) while processing attachment 89639 [details] on bug 58566. Bot: eseidel-cq-sf Port: Mac Platform: Mac OS X 10.6.4
WebKit Commit Bot
Comment 24 2011-04-15 01:07:41 PDT
Created attachment 89754 [details] Failure diff from eseidel-cq-sf
WebKit Commit Bot
Comment 25 2011-04-15 09:17:20 PDT
The commit-queue just saw http/tests/misc/favicon-loads-with-icon-loading-override.html flake (Text diff mismatch) while processing attachment 89771 [details] on bug 58651. Bot: eseidel-cq-sf Port: Mac Platform: Mac OS X 10.6.4
WebKit Commit Bot
Comment 26 2011-04-15 09:17:23 PDT
Created attachment 89795 [details] Failure diff from eseidel-cq-sf
WebKit Commit Bot
Comment 27 2011-04-15 16:32:49 PDT
The commit-queue just saw http/tests/misc/favicon-loads-with-icon-loading-override.html flake (Text diff mismatch) while processing attachment 89669 [details] on bug 58573. Bot: eseidel-cq-sf Port: Mac Platform: Mac OS X 10.6.4
WebKit Commit Bot
Comment 28 2011-04-15 16:32:51 PDT
Created attachment 89876 [details] Failure diff from eseidel-cq-sf
WebKit Commit Bot
Comment 29 2011-04-17 11:57:28 PDT
The commit-queue just saw http/tests/misc/favicon-loads-with-icon-loading-override.html flake (Text diff mismatch) while processing attachment 89949 [details] on bug 58742. Bot: eseidel-cq-sf Port: Mac Platform: Mac OS X 10.6.4
WebKit Commit Bot
Comment 30 2011-04-17 11:57:30 PDT
Created attachment 89954 [details] Failure diff from eseidel-cq-sf
WebKit Commit Bot
Comment 31 2011-04-18 20:08:46 PDT
The commit-queue just saw http/tests/misc/favicon-loads-with-icon-loading-override.html flake (Text diff mismatch) while processing attachment 90131 [details] on bug 58859. Bot: eseidel-cq-sf Port: Mac Platform: Mac OS X 10.6.4
WebKit Commit Bot
Comment 32 2011-04-18 20:08:48 PDT
Created attachment 90135 [details] Failure diff from eseidel-cq-sf
WebKit Commit Bot
Comment 33 2011-04-18 21:25:38 PDT
The commit-queue just saw http/tests/misc/favicon-loads-with-icon-loading-override.html flake (Text diff mismatch) while processing attachment 90098 [details] on bug 58346. Bot: cr-jail-7 Port: Mac Platform: Mac OS X 10.6.6
WebKit Commit Bot
Comment 34 2011-04-18 21:25:40 PDT
Created attachment 90139 [details] Failure diff from cr-jail-7
WebKit Commit Bot
Comment 35 2011-04-18 22:05:56 PDT
The commit-queue just saw http/tests/misc/favicon-loads-with-icon-loading-override.html flake (Text diff mismatch) while processing attachment 90075 [details] on bug 58813. Bot: eseidel-cq-sf Port: Mac Platform: Mac OS X 10.6.4
WebKit Commit Bot
Comment 36 2011-04-18 22:05:58 PDT
Created attachment 90143 [details] Failure diff from eseidel-cq-sf
WebKit Commit Bot
Comment 37 2011-04-19 12:20:57 PDT
The commit-queue just saw http/tests/misc/favicon-loads-with-icon-loading-override.html flake (Text diff mismatch) while processing attachment 90114 [details] on bug 58419. Bot: eseidel-cq-sf Port: Mac Platform: Mac OS X 10.6.4
WebKit Commit Bot
Comment 38 2011-04-19 12:20:59 PDT
Created attachment 90236 [details] Failure diff from eseidel-cq-sf
WebKit Commit Bot
Comment 39 2011-04-19 20:32:26 PDT
The commit-queue just saw http/tests/misc/favicon-loads-with-icon-loading-override.html flake (Text diff mismatch) while processing attachment 90271 [details] on bug 57678. Bot: cr-jail-7 Port: Mac Platform: Mac OS X 10.6.6
WebKit Commit Bot
Comment 40 2011-04-19 20:32:29 PDT
Created attachment 90297 [details] Failure diff from cr-jail-7
WebKit Commit Bot
Comment 41 2011-04-20 21:10:43 PDT
The commit-queue just saw http/tests/misc/favicon-loads-with-icon-loading-override.html flake (Text diff mismatch) while processing attachment 90152 [details] on bug 58865. Bot: eseidel-cq-sf Port: Mac Platform: Mac OS X 10.6.4
WebKit Commit Bot
Comment 42 2011-04-20 21:10:45 PDT
Created attachment 90484 [details] Failure diff from eseidel-cq-sf
Eric Seidel (no email)
Comment 43 2011-04-20 21:21:26 PDT
The diff is the same every time. We're also no longer stopping after the first failure, so I can state for sure that when this has recently flaked, its been the only flake. Ha. Looking at the test it looks obviously flaky. It sets up the loader callbacks on onload. :) It's very possible that the favicon has already loaded by then! We just need to move the setup out of onload and into a <script> tag to fix this.
Eric Seidel (no email)
Comment 44 2011-04-20 21:25:11 PDT
Oh. Maybe the reload is supposed to trigger the callbacks to fire again... in which case it would not be obviously racy. Looking.
WebKit Commit Bot
Comment 45 2011-04-20 22:56:22 PDT
The commit-queue just saw http/tests/misc/favicon-loads-with-icon-loading-override.html flake (Text diff mismatch) while processing attachment 90447 [details] on bug 59040. Bot: eseidel-cq-sf Port: Mac Platform: Mac OS X 10.6.4
WebKit Commit Bot
Comment 46 2011-04-20 22:56:23 PDT
Created attachment 90497 [details] Failure diff from eseidel-cq-sf
WebKit Commit Bot
Comment 47 2011-04-21 00:41:27 PDT
The commit-queue just saw http/tests/misc/favicon-loads-with-icon-loading-override.html flake (Text diff mismatch) while processing attachment 90496 [details] on bug 59076. Bot: eseidel-cq-sf Port: Mac Platform: Mac OS X 10.6.4
WebKit Commit Bot
Comment 48 2011-04-21 00:41:29 PDT
Created attachment 90502 [details] Failure diff from eseidel-cq-sf
WebKit Commit Bot
Comment 49 2011-04-21 08:18:56 PDT
The commit-queue just saw http/tests/misc/favicon-loads-with-icon-loading-override.html flake (Text diff mismatch) while processing attachment 90523 [details] on bug 59097. Bot: cr-jail-7 Port: Mac Platform: Mac OS X 10.6.6
WebKit Commit Bot
Comment 50 2011-04-21 08:18:59 PDT
Created attachment 90537 [details] Failure diff from cr-jail-7
WebKit Commit Bot
Comment 51 2011-04-21 08:55:00 PDT
The commit-queue just saw http/tests/misc/favicon-loads-with-icon-loading-override.html flake (Text diff mismatch) while processing attachment 90284 [details] on bug 55021. Bot: eseidel-cq-sf Port: Mac Platform: Mac OS X 10.6.4
WebKit Commit Bot
Comment 52 2011-04-21 08:55:02 PDT
Created attachment 90543 [details] Failure diff from eseidel-cq-sf
WebKit Commit Bot
Comment 53 2011-04-21 12:06:06 PDT
The commit-queue just saw http/tests/misc/favicon-loads-with-icon-loading-override.html flake (Text diff mismatch) while processing attachment 90549 [details] on bug 58772. Bot: eseidel-cq-sf Port: Mac Platform: Mac OS X 10.6.4
WebKit Commit Bot
Comment 54 2011-04-21 12:06:08 PDT
Created attachment 90571 [details] Failure diff from eseidel-cq-sf
Alice Liu
Comment 55 2011-04-21 12:52:50 PDT
(In reply to comment #43) > The diff is the same every time. > > We're also no longer stopping after the first failure, so I can state for sure that when this has recently flaked, its been the only flake. > > Ha. Looking at the test it looks obviously flaky. It sets up the loader callbacks on onload. :) It's very possible that the favicon has already loaded by then! > > We just need to move the setup out of onload and into a <script> tag to fix this. Couple things worth mentioning: 1) this test is basically a clone of http://trac.webkit.org/browser/trunk/LayoutTests/http/tests/misc/favicon-loads-with-images-disabled.html. The only thing difference in this test is the preference override. 2) This test is only flaking on 2 particular commit-queue bots, mostly eseidel-cq-sf and sometimes cr-jail-7. The various core testers for Mac and Windows aren't failing this test.
WebKit Commit Bot
Comment 56 2011-04-21 14:19:11 PDT
The commit-queue just saw http/tests/misc/favicon-loads-with-icon-loading-override.html flake (Text diff mismatch) while processing attachment 90321 [details] on bug 58969. Bot: eseidel-cq-sf Port: Mac Platform: Mac OS X 10.6.4
WebKit Commit Bot
Comment 57 2011-04-21 14:19:13 PDT
Created attachment 90599 [details] Failure diff from eseidel-cq-sf
Eric Seidel (no email)
Comment 58 2011-04-22 09:34:38 PDT
I've updated eseidel-cq-sf to 10.6.7. I'm also now attempting to reproduce this failure locally on my work machine.
Eric Seidel (no email)
Comment 59 2011-04-22 09:46:13 PDT
If I run the test twice in a row it fails in exactly the way seen on the bots: run-webkit-tests http/tests/misc/favicon-loads-with-icon-loading-override.html http/tests/misc/favicon-loads-with-icon-loading-override.html I suspect that we don't show loader callbacks when we pull something from the cache. I suspect that sometimes the favicon gets into the cache before we start the test (by issuing a reload) and thus we never send callbacks for it.
Eric Seidel (no email)
Comment 60 2011-04-22 09:47:38 PDT
For reference, the other test which Alice mentioned does not fail when run twice in a row: run-webkit-tests http/tests/misc/favicon-loads-with-images-disabled.html http/tests/misc/favicon-loads-with-images-disabled.html
Eric Seidel (no email)
Comment 61 2011-04-22 09:49:52 PDT
(In reply to comment #55) > 2) This test is only flaking on 2 particular commit-queue bots, mostly eseidel-cq-sf and sometimes cr-jail-7. The various core testers for Mac and Windows aren't failing this test. There are many tests which fail on the real bots that we just don't notice because they don't fail often enough for someone to see (and file a bug on). Because the commit-queues always log flakes to these bugs we are better able to track flakes on the cq. That said, it's very possible this is a cq-only failure. However being able to reproduce the failure on my work machine makes me think this is probably flaky everywhere (but only when the ico happens to load before the body's onload event fires).
Eric Seidel (no email)
Comment 62 2011-04-22 09:51:21 PDT
Unfortunately, even if I'm correct in my flake theory, I don't know of any way (currently) to correct the run-twice failure. It seems the loader callbacks never fire when things are pulled from the cache. We'd need a way to clear the cache before this test, which I don't think we have yet.
WebKit Commit Bot
Comment 63 2011-04-22 11:48:21 PDT
The commit-queue just saw http/tests/misc/favicon-loads-with-icon-loading-override.html flake (Text diff mismatch) while processing attachment 88459 [details] on bug 57959. Bot: eseidel-cq-sf Port: Mac Platform: Mac OS X 10.6.6
WebKit Commit Bot
Comment 64 2011-04-22 11:48:23 PDT
Created attachment 90733 [details] Failure diff from eseidel-cq-sf
WebKit Commit Bot
Comment 65 2011-04-22 14:18:02 PDT
The commit-queue just saw http/tests/misc/favicon-loads-with-icon-loading-override.html flake (Text diff mismatch) while processing attachment 90725 [details] on bug 58643. Bot: eseidel-cq-sf Port: Mac Platform: Mac OS X 10.6.6
WebKit Commit Bot
Comment 66 2011-04-22 14:18:05 PDT
Created attachment 90759 [details] Failure diff from eseidel-cq-sf
Eric Seidel (no email)
Comment 67 2011-04-22 14:38:52 PDT
Given that this test fails when run twice locally, and I can't think of any good way to fix that, I think we should consider skipping it. It's possible that the flakiness could be prevented by moving the code execution to before the favicon is loaded. But it still might be flaky due to the preload scanner in that case too. Unless there is a way to clear the cache or always make the subresource loader callbacks fire, even when things are in the cache, I don't see a way to fix this test as written.
WebKit Commit Bot
Comment 68 2011-04-24 02:14:07 PDT
The commit-queue just saw http/tests/misc/favicon-loads-with-icon-loading-override.html flake (Text diff mismatch) while processing attachment 90874 [details] on bug 59296. Bot: eseidel-cq-sf Port: Mac Platform: Mac OS X 10.6.6
WebKit Commit Bot
Comment 69 2011-04-24 02:14:08 PDT
Created attachment 90880 [details] Failure diff from eseidel-cq-sf
WebKit Commit Bot
Comment 70 2011-04-26 07:37:59 PDT
The commit-queue just saw http/tests/misc/favicon-loads-with-icon-loading-override.html flake (Text diff mismatch) while processing attachment 91082 [details] on bug 43903. Bot: eseidel-cq-sf Port: Mac Platform: Mac OS X 10.6.6
WebKit Commit Bot
Comment 71 2011-04-26 07:38:01 PDT
Created attachment 91103 [details] Failure diff from eseidel-cq-sf
Eric Seidel (no email)
Comment 72 2011-04-26 07:38:42 PDT
I'll see if I can find Alice or Bradee at the conference today and we can chat about this bug. :)
WebKit Commit Bot
Comment 73 2011-04-28 05:57:21 PDT
The commit-queue just saw http/tests/misc/favicon-loads-with-icon-loading-override.html flake (Text diff mismatch) while processing attachment 91287 [details] on bug 59465. Bot: cr-jail-7 Port: Mac Platform: Mac OS X 10.6.6
WebKit Commit Bot
Comment 74 2011-04-28 05:57:24 PDT
Created attachment 91475 [details] Failure diff from cr-jail-7
WebKit Commit Bot
Comment 75 2011-05-04 19:32:31 PDT
The commit-queue just saw http/tests/misc/favicon-loads-with-icon-loading-override.html flake (Text diff mismatch) while processing attachment 92349 [details] on bug 49902. Bot: eseidel-cq-sf Port: Mac Platform: Mac OS X 10.6.6
WebKit Commit Bot
Comment 76 2011-05-04 19:32:33 PDT
Created attachment 92361 [details] Failure diff from eseidel-cq-sf
WebKit Commit Bot
Comment 77 2011-05-06 00:46:33 PDT
The commit-queue just saw http/tests/misc/favicon-loads-with-icon-loading-override.html flake (Text diff mismatch) while processing attachment 92539 [details] on bug 60338. Bot: cr-jail-8 Port: Mac Platform: Mac OS X 10.6.7
WebKit Commit Bot
Comment 78 2011-05-06 00:46:37 PDT
Created attachment 92553 [details] Failure diff from cr-jail-8
WebKit Commit Bot
Comment 79 2011-05-07 07:33:41 PDT
The commit-queue just saw http/tests/misc/favicon-loads-with-icon-loading-override.html flake (Text diff mismatch) while processing attachment 92661 [details] on bug 60420. Bot: eseidel-cq-sf Port: Mac Platform: Mac OS X 10.6.6
WebKit Commit Bot
Comment 80 2011-05-07 07:33:43 PDT
Created attachment 92689 [details] Failure diff from eseidel-cq-sf
WebKit Commit Bot
Comment 81 2011-05-07 22:17:36 PDT
The commit-queue just saw http/tests/misc/favicon-loads-with-icon-loading-override.html flake (Text diff mismatch) while processing attachment 92654 [details] on bug 60393. Bot: eseidel-cq-sf Port: Mac Platform: Mac OS X 10.6.6
WebKit Commit Bot
Comment 82 2011-05-07 22:17:38 PDT
Created attachment 92726 [details] Failure diff from eseidel-cq-sf
WebKit Commit Bot
Comment 83 2011-05-08 11:50:47 PDT
The commit-queue just saw http/tests/misc/favicon-loads-with-icon-loading-override.html flake (Text diff mismatch) while processing attachment 92688 [details] on bug 60435. Bot: eseidel-cq-sf Port: Mac Platform: Mac OS X 10.6.6
WebKit Commit Bot
Comment 84 2011-05-08 11:50:50 PDT
Created attachment 92738 [details] Failure diff from eseidel-cq-sf
WebKit Commit Bot
Comment 85 2011-05-08 23:33:22 PDT
The commit-queue just saw http/tests/misc/favicon-loads-with-icon-loading-override.html flake (Text diff mismatch) while processing attachment 92756 [details] on bug 43704. Bot: eseidel-cq-sf Port: Mac Platform: Mac OS X 10.6.6
WebKit Commit Bot
Comment 86 2011-05-08 23:33:24 PDT
Created attachment 92760 [details] Failure diff from eseidel-cq-sf
WebKit Commit Bot
Comment 87 2011-05-09 07:59:11 PDT
The commit-queue just saw http/tests/misc/favicon-loads-with-icon-loading-override.html flake (Text diff mismatch) while processing attachment 92785 [details] on bug 60387. Bot: eseidel-cq-sf Port: Mac Platform: Mac OS X 10.6.6
WebKit Commit Bot
Comment 88 2011-05-09 07:59:13 PDT
Created attachment 92791 [details] Failure diff from eseidel-cq-sf
WebKit Commit Bot
Comment 89 2011-05-09 14:05:42 PDT
The commit-queue just saw http/tests/misc/favicon-loads-with-icon-loading-override.html flake (Text diff mismatch) while processing attachment 91805 [details] on bug 57137. Bot: eseidel-cq-sf Port: Mac Platform: Mac OS X 10.6.6
WebKit Commit Bot
Comment 90 2011-05-09 14:05:44 PDT
Created attachment 92844 [details] Failure diff from eseidel-cq-sf
WebKit Commit Bot
Comment 91 2011-05-09 18:52:32 PDT
The commit-queue just saw http/tests/misc/favicon-loads-with-icon-loading-override.html flake (Text diff mismatch) while processing attachment 92895 [details] on bug 60517. Bot: eseidel-cq-sf Port: Mac Platform: Mac OS X 10.6.6
WebKit Commit Bot
Comment 92 2011-05-09 18:52:34 PDT
Created attachment 92904 [details] Failure diff from eseidel-cq-sf
WebKit Commit Bot
Comment 93 2011-05-10 10:44:00 PDT
The commit-queue just saw http/tests/misc/favicon-loads-with-icon-loading-override.html flake (Text diff mismatch) while processing attachment 92951 [details] on bug 60320. Bot: eseidel-cq-sf Port: Mac Platform: Mac OS X 10.6.6
WebKit Commit Bot
Comment 94 2011-05-10 10:44:02 PDT
Created attachment 92977 [details] Failure diff from eseidel-cq-sf
Eric Seidel (no email)
Comment 95 2011-05-10 11:32:47 PDT
I've run webkit-patch find-flaky-tests and failed to find this flaking on the official bots. I will try upgrading eseidel-cq-sf to 10.6.7 and see if the problem goes away.
WebKit Commit Bot
Comment 96 2011-05-10 18:41:26 PDT
The commit-queue just saw http/tests/misc/favicon-loads-with-icon-loading-override.html flake (Text diff mismatch) while processing attachment 93055 [details] on bug 57127. Bot: eseidel-cq-sf Port: Mac Platform: Mac OS X 10.6.7
WebKit Commit Bot
Comment 97 2011-05-10 18:41:28 PDT
Created attachment 93060 [details] Failure diff from eseidel-cq-sf
Eric Seidel (no email)
Comment 98 2011-05-10 22:08:18 PDT
Obviously that didn't work. eseidel-cq-sf is not quite a stock copy of Snow Leopard, so that may be related. However both cr-jail-8 an cr-jail-7 (stock snow leopard 2-core mac minis) have seen this failure. I do believe this is a race (due to the multi-core bots) but I don't know why it's showing up on the commit-queue when we haven't noticed it on the build.webkit.org bots yet.
WebKit Commit Bot
Comment 99 2011-05-11 09:54:12 PDT
The commit-queue just saw http/tests/misc/favicon-loads-with-icon-loading-override.html flake (Text diff mismatch) while processing attachment 92982 [details] on bug 60477. Bot: eseidel-cq-sf Port: Mac Platform: Mac OS X 10.6.7
WebKit Commit Bot
Comment 100 2011-05-11 09:54:14 PDT
Created attachment 93137 [details] Failure diff from eseidel-cq-sf
WebKit Commit Bot
Comment 101 2011-05-11 12:09:12 PDT
The commit-queue just saw http/tests/misc/favicon-loads-with-icon-loading-override.html flake (Text diff mismatch) while processing attachment 93145 [details] on bug 60521. Bot: eseidel-cq-sf Port: Mac Platform: Mac OS X 10.6.7
WebKit Commit Bot
Comment 102 2011-05-11 12:09:14 PDT
Created attachment 93154 [details] Failure diff from eseidel-cq-sf
WebKit Commit Bot
Comment 103 2011-05-11 13:38:34 PDT
The commit-queue just saw http/tests/misc/favicon-loads-with-icon-loading-override.html flake (Text diff mismatch) while processing attachment 93132 [details] on bug 60634. Bot: eseidel-cq-sf Port: Mac Platform: Mac OS X 10.6.7
WebKit Commit Bot
Comment 104 2011-05-11 13:38:36 PDT
Created attachment 93172 [details] Failure diff from eseidel-cq-sf
Eric Seidel (no email)
Comment 105 2011-05-11 13:41:31 PDT
Maybe I need to shut off that bot. I think this test is likely flaky, but I don't understand why it mostly flakes on that one bot.
WebKit Commit Bot
Comment 106 2011-05-11 15:47:27 PDT
The commit-queue just saw http/tests/misc/favicon-loads-with-icon-loading-override.html flake (Text diff mismatch) while processing attachment 92912 [details] on bug 60508. Bot: eseidel-cq-sf Port: Mac Platform: Mac OS X 10.6.7
WebKit Commit Bot
Comment 107 2011-05-11 15:47:29 PDT
Created attachment 93199 [details] Failure diff from eseidel-cq-sf
WebKit Commit Bot
Comment 108 2011-05-12 00:40:35 PDT
The commit-queue just saw http/tests/misc/favicon-loads-with-icon-loading-override.html flake (Text diff mismatch) while processing attachment 92936 [details] on bug 60542. Bot: eseidel-cq-sf Port: Mac Platform: Mac OS X 10.6.7
WebKit Commit Bot
Comment 109 2011-05-12 00:40:37 PDT
Created attachment 93262 [details] Failure diff from eseidel-cq-sf
WebKit Commit Bot
Comment 110 2011-05-12 11:24:49 PDT
The commit-queue just saw http/tests/misc/favicon-loads-with-icon-loading-override.html flake (Text diff mismatch) while processing attachment 93302 [details] on bug 60519. Bot: eseidel-cq-sf Port: Mac Platform: Mac OS X 10.6.7
WebKit Commit Bot
Comment 111 2011-05-12 11:24:52 PDT
Created attachment 93314 [details] Failure diff from eseidel-cq-sf
WebKit Commit Bot
Comment 112 2011-05-12 22:22:10 PDT
The commit-queue just saw http/tests/misc/favicon-loads-with-icon-loading-override.html flake (Text diff mismatch) while processing attachment 93394 [details] on bug 58999. Bot: eseidel-cq-sf Port: Mac Platform: Mac OS X 10.6.7
WebKit Commit Bot
Comment 113 2011-05-12 22:22:12 PDT
Created attachment 93403 [details] Failure diff from eseidel-cq-sf
WebKit Commit Bot
Comment 114 2011-05-16 10:28:12 PDT
The commit-queue just saw http/tests/misc/favicon-loads-with-icon-loading-override.html flake (Text diff mismatch) while processing attachment 93619 [details] on bug 60874. Bot: eseidel-cq-sf Port: Mac Platform: Mac OS X 10.6.7
WebKit Commit Bot
Comment 115 2011-05-16 10:28:14 PDT
Created attachment 93666 [details] Failure diff from eseidel-cq-sf
WebKit Commit Bot
Comment 116 2011-05-16 16:28:50 PDT
The commit-queue just saw http/tests/misc/favicon-loads-with-icon-loading-override.html flake (Text diff mismatch) while processing attachment 93701 [details] on bug 60926. Bot: eseidel-cq-sf Port: Mac Platform: Mac OS X 10.6.7
WebKit Commit Bot
Comment 117 2011-05-16 16:28:52 PDT
Created attachment 93711 [details] Failure diff from eseidel-cq-sf
WebKit Commit Bot
Comment 118 2011-05-18 12:33:00 PDT
The commit-queue just saw http/tests/misc/favicon-loads-with-icon-loading-override.html flake (Text diff mismatch) while processing attachment 93940 [details] on bug 61080. Bot: eseidel-cq-sf Port: Mac Platform: Mac OS X 10.6.7
WebKit Commit Bot
Comment 119 2011-05-18 12:33:02 PDT
Created attachment 93964 [details] Failure diff from eseidel-cq-sf
WebKit Commit Bot
Comment 120 2011-05-18 16:35:49 PDT
The commit-queue just saw http/tests/misc/favicon-loads-with-icon-loading-override.html flake (Text diff mismatch) while processing attachment 93968 [details] on bug 39852. Bot: eseidel-cq-sf Port: Mac Platform: Mac OS X 10.6.7
WebKit Commit Bot
Comment 121 2011-05-18 16:35:51 PDT
Created attachment 93999 [details] Failure diff from eseidel-cq-sf
WebKit Commit Bot
Comment 122 2011-05-18 17:14:05 PDT
The commit-queue just saw http/tests/misc/favicon-loads-with-icon-loading-override.html flake (Text diff mismatch) while processing attachment 93987 [details] on bug 61003. Bot: eseidel-cq-sf Port: Mac Platform: Mac OS X 10.6.7
WebKit Commit Bot
Comment 123 2011-05-18 17:14:08 PDT
Created attachment 94004 [details] Failure diff from eseidel-cq-sf
WebKit Commit Bot
Comment 124 2011-05-19 02:31:10 PDT
The commit-queue just saw http/tests/misc/favicon-loads-with-icon-loading-override.html flake (Text diff mismatch) while processing attachment 93894 [details] on bug 61034. Bot: eseidel-cq-sf Port: Mac Platform: Mac OS X 10.6.7
WebKit Commit Bot
Comment 125 2011-05-19 02:31:12 PDT
Created attachment 94053 [details] Failure diff from eseidel-cq-sf
WebKit Commit Bot
Comment 126 2011-05-23 07:19:19 PDT
The commit-queue just saw http/tests/misc/favicon-loads-with-icon-loading-override.html flake (Text diff mismatch) while processing attachment 94265 [details] on bug 42669. Bot: cr-jail-4 Port: Mac Platform: Mac OS X 10.6.7
WebKit Commit Bot
Comment 127 2011-05-23 07:19:21 PDT
Created attachment 94423 [details] Failure diff from cr-jail-4
WebKit Commit Bot
Comment 128 2011-05-23 21:08:06 PDT
The commit-queue just saw http/tests/misc/favicon-loads-with-icon-loading-override.html flake (Text diff mismatch) while processing attachment 94506 [details] on bug 56627. Bot: cr-jail-4 Port: Mac Platform: Mac OS X 10.6.7
WebKit Commit Bot
Comment 129 2011-05-23 21:08:09 PDT
Created attachment 94556 [details] Failure diff from cr-jail-4
WebKit Commit Bot
Comment 130 2011-05-26 13:08:21 PDT
The commit-queue just saw http/tests/misc/favicon-loads-with-icon-loading-override.html flake (Text diff mismatch) while processing attachment 94980 [details] on bug 61535. Bot: cr-jail-4 Port: Mac Platform: Mac OS X 10.6.7
WebKit Commit Bot
Comment 131 2011-05-26 13:08:24 PDT
Created attachment 95024 [details] Failure diff from cr-jail-4
WebKit Commit Bot
Comment 132 2011-06-01 06:01:52 PDT
The commit-queue just saw http/tests/misc/favicon-loads-with-icon-loading-override.html flake (Text diff mismatch) while processing attachment 95539 [details] on bug 61835. Bot: cr-jail-8 Port: Mac Platform: Mac OS X 10.6.7
WebKit Commit Bot
Comment 133 2011-06-01 06:01:55 PDT
Created attachment 95590 [details] Failure diff from cr-jail-8
WebKit Commit Bot
Comment 134 2011-06-04 06:29:14 PDT
The commit-queue just saw http/tests/misc/favicon-loads-with-icon-loading-override.html flake (Text diff mismatch) while processing attachment 96016 [details] on bug 62087. Bot: cr-jail-7 Port: Mac Platform: Mac OS X 10.6.7
WebKit Commit Bot
Comment 135 2011-06-04 06:29:17 PDT
Created attachment 96021 [details] Failure diff from cr-jail-7
Note You need to log in before you can comment on or make changes to this bug.