Bug 58813 - remove tests from test_expectations.txt, as they now pass
Summary: remove tests from test_expectations.txt, as they now pass
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Mike Reed
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-18 12:46 PDT by Mike Reed
Modified: 2011-04-18 22:06 PDT (History)
3 users (show)

See Also:


Attachments
Patch (1.50 KB, patch)
2011-04-18 12:47 PDT, Mike Reed
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Reed 2011-04-18 12:46:50 PDT
remove tests from test_expectations.txt, as they now pass
Comment 1 Mike Reed 2011-04-18 12:47:36 PDT
Created attachment 90075 [details]
Patch
Comment 2 Mike Reed 2011-04-18 12:48:36 PDT
fast/canvas/canvas-strokeRect-alpha-shadow.html
fast/canvas/canvas-strokePath-alpha-shadow.html

these now pass
Comment 3 Kenneth Russell 2011-04-18 13:04:59 PDT
Comment on attachment 90075 [details]
Patch

Looks good.
Comment 4 WebKit Commit Bot 2011-04-18 14:45:39 PDT
Comment on attachment 90075 [details]
Patch

Rejecting attachment 90075 [details] from commit-queue.

Failed to run "[u'zip', u'-r', u'../commit-queue-logs/58813-layout-test-results-1.zip', u'/tmp/layout-test-resul..." exit_code: 12

	zip warning: name not matched: /tmp/layout-test-results

zip error: Nothing to do! (try: zip -r ../commit-queue-logs/58813-layout-test-results-1.zip . -i /tmp/layout-test-results)

Full output: http://queues.webkit.org/results/8470109
Comment 5 Kenneth Russell 2011-04-18 15:12:55 PDT
Comment on attachment 90075 [details]
Patch

Not sure what went wrong with the last attempt in the commit queue. Trying again.
Comment 6 WebKit Commit Bot 2011-04-18 20:39:48 PDT
Comment on attachment 90075 [details]
Patch

Clearing flags on attachment: 90075

Committed r84218: <http://trac.webkit.org/changeset/84218>
Comment 7 WebKit Commit Bot 2011-04-18 20:39:52 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 WebKit Commit Bot 2011-04-18 22:06:21 PDT
The commit-queue encountered the following flaky tests while processing attachment 90075 [details]:

http/tests/misc/favicon-loads-with-icon-loading-override.html bug 58412 (author: alice.liu@apple.com)
http/tests/xmlhttprequest/cookies.html bug 51976 (authors: ap@webkit.org and eric@webkit.org)
The commit-queue is continuing to process your patch.