Bug 58447 – Web Inspector: ResourceResponse should have encodedDataLength field for synchronous requests transfer size

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Vsevolod Vlasov]

Add encodedDataLength field to ResourceResponse and use it for synchronous requests transfer size

[Vsevolod Vlasov]

Created attachment 89386 [details]
Patch

[Pavel Feldman]

Comment on attachment 89386 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=89386&action=review

> Source/WebCore/loader/FrameLoader.cpp:2829
> +    notifier()->sendRemainingDelegateMessages(m_documentLoader.get(), identifier, response, data.size(), static_cast<int>(response.encodedDataLength()), error);

what are the implications of this change?

> Source/WebCore/platform/network/ResourceResponseBase.h:68
> +    long long encodedDataLength() const;

This should be a part of ResourceLoadInfo.

[Vsevolod Vlasov]

Created attachment 89558 [details]
Patch

(In reply to comment #2)
> (From update of attachment 89386 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=89386&action=review
> 
> > Source/WebCore/loader/FrameLoader.cpp:2829
> > +    notifier()->sendRemainingDelegateMessages(m_documentLoader.get(), identifier, response, data.size(), static_cast<int>(response.encodedDataLength()), error);
> 
> what are the implications of this change?
This parameter was introduced by my previous change and the value passed here was not correct. Now we are passing a correct value that will be forwarded to didReceiveData.

> > Source/WebCore/platform/network/ResourceResponseBase.h:68
> > +    long long encodedDataLength() const;
> 
> This should be a part of ResourceLoadInfo.
Done.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 89558 [details]:

http/tests/misc/favicon-loads-with-icon-loading-override.html bug 58412 (author: [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 89558 [details]
Patch

Clearing flags on attachment: 89558

Committed r83942: <http://trac.webkit.org/changeset/83942>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.