Bug 58447 - Web Inspector: ResourceResponse should have encodedDataLength field for synchronous requests transfer size
Summary: Web Inspector: ResourceResponse should have encodedDataLength field for synch...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-13 09:10 PDT by Vsevolod Vlasov
Modified: 2011-04-14 21:30 PDT (History)
11 users (show)

See Also:

Attachments
Patch (3.96 KB, patch)
2011-04-13 09:18 PDT, Vsevolod Vlasov 		pfeldman: review-
Details | Formatted Diff | Diff
Patch (4.56 KB, patch)
2011-04-14 05:12 PDT, Vsevolod Vlasov 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vsevolod Vlasov 2011-04-13 09:10:19 PDT 
Add encodedDataLength field to ResourceResponse and use it for synchronous requests transfer size
Comment 1 Vsevolod Vlasov 2011-04-13 09:18:53 PDT 
Created attachment 89386 [details]
Patch
Comment 2 Pavel Feldman 2011-04-14 03:55:08 PDT 
Comment on attachment 89386 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=89386&action=review

> Source/WebCore/loader/FrameLoader.cpp:2829
> +    notifier()->sendRemainingDelegateMessages(m_documentLoader.get(), identifier, response, data.size(), static_cast<int>(response.encodedDataLength()), error);

what are the implications of this change?

> Source/WebCore/platform/network/ResourceResponseBase.h:68
> +    long long encodedDataLength() const;

This should be a part of ResourceLoadInfo.
Comment 3 Vsevolod Vlasov 2011-04-14 05:12:43 PDT 
Created attachment 89558 [details]
Patch

(In reply to comment #2)
> (From update of attachment 89386 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=89386&action=review
> 
> > Source/WebCore/loader/FrameLoader.cpp:2829
> > +    notifier()->sendRemainingDelegateMessages(m_documentLoader.get(), identifier, response, data.size(), static_cast<int>(response.encodedDataLength()), error);
> 
> what are the implications of this change?
This parameter was introduced by my previous change and the value passed here was not correct. Now we are passing a correct value that will be forwarded to didReceiveData.

> > Source/WebCore/platform/network/ResourceResponseBase.h:68
> > +    long long encodedDataLength() const;
> 
> This should be a part of ResourceLoadInfo.
Done.
Comment 4 WebKit Commit Bot 2011-04-14 21:27:10 PDT 
The commit-queue encountered the following flaky tests while processing attachment 89558 [details]:

http/tests/misc/favicon-loads-with-icon-loading-override.html bug 58412 (author: alice.liu@apple.com)
The commit-queue is continuing to process your patch.
Comment 5 WebKit Commit Bot 2011-04-14 21:30:11 PDT 
Comment on attachment 89558 [details]
Patch

Clearing flags on attachment: 89558

Committed r83942: <http://trac.webkit.org/changeset/83942>
Comment 6 WebKit Commit Bot 2011-04-14 21:30:15 PDT 
All reviewed patches have been landed.  Closing bug.