Bug 60435 - [EFL] Replace ewk_view_select_* functions by extending Ewk_Editor_Command enum
Summary: [EFL] Replace ewk_view_select_* functions by extending Ewk_Editor_Command enum
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2011-05-07 06:49 PDT by Kamil Blank
Modified: 2011-05-08 11:53 PDT (History)
8 users (show)

See Also:

patch (5.31 KB, patch)
2011-05-07 06:54 PDT, Kamil Blank
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kamil Blank 2011-05-07 06:49:09 PDT
As a continuation of bug 54439 (https://bugs.webkit.org/show_bug.cgi?id=54439) 

I'd like to propose patch which replaces existing editor commands functions

EAPI Eina_Bool    ewk_view_select_none(Evas_Object *o);
EAPI Eina_Bool    ewk_view_select_all(Evas_Object *o);
EAPI Eina_Bool    ewk_view_select_paragraph(Evas_Object *o);
EAPI Eina_Bool    ewk_view_select_sentence(Evas_Object *o);
EAPI Eina_Bool    ewk_view_select_line(Evas_Object *o);
EAPI Eina_Bool    ewk_view_select_word(Evas_Object *o);

by adding new enums into Ewk_Editor_Command.
Comment 1 Kamil Blank 2011-05-07 06:54:14 PDT
Created attachment 92688 [details]
Comment 2 WebKit Commit Bot 2011-05-08 11:50:55 PDT
The commit-queue encountered the following flaky tests while processing attachment 92688 [details]:

http/tests/misc/favicon-loads-with-icon-loading-override.html bug 58412 (author: alice.liu@apple.com)
The commit-queue is continuing to process your patch.
Comment 3 WebKit Commit Bot 2011-05-08 11:53:50 PDT
Comment on attachment 92688 [details]

Clearing flags on attachment: 92688

Committed r86031: <http://trac.webkit.org/changeset/86031>
Comment 4 WebKit Commit Bot 2011-05-08 11:53:54 PDT
All reviewed patches have been landed.  Closing bug.