Bug 57959 – Should assert on invalid type in FEComponentTransfer::apply

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Justin Schuh]

Should assert on invalid type in FEComponentTransfer::apply

[Justin Schuh]

Created attachment 88459 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 88459 [details]
Patch

Makes sense.

[Eric Seidel (no email)]

Comment on attachment 88459 [details]
Patch

Actually, shouldn't we do this before we loop over all the rgba values (in a separate loop?)  This seems it would make debug behavior needlessly slow.

[Justin Schuh]

(In reply to comment #3)
> (From update of attachment 88459 [details])
> Actually, shouldn't we do this before we loop over all the rgba values (in a separate loop?)  This seems it would make debug behavior needlessly slow.

I think this way is easier to follow than a duplicate loop blocked out with debug #ifdefs. And since it's an assert (that doesn't affect release), I think readability should be the priority.

[Justin Schuh]

Eric, did I sufficiently respond to your question and do you have any objection to me landing it?

[Eric Seidel (no email)]

I'm not standing in the way of this patch, no, you're welcome to land.

[Justin Schuh]

(In reply to comment #6)
> I'm not standing in the way of this patch, no, you're welcome to land.

Thanks. It slipped off my radar and I was trying to do some cleanup.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 88459 [details]:

http/tests/misc/favicon-loads-with-icon-loading-override.html bug 58412 (author: [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 88459 [details]
Patch

Rejecting attachment 88459 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-8', 'apply-..." exit_code: 2

Last 500 characters of output:
" exit_code: 1

Parsed 2 diffs from patch file(s).
patching file Source/WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebCore/platform/graphics/filters/FEComponentTransfer.cpp
Hunk #1 FAILED at 33.
Hunk #2 FAILED at 170.
2 out of 2 hunks FAILED -- saving rejects to file Source/WebCore/platform/graphics/filters/FEComponentTransfer.cpp.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Eric Seidel', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/8486842

[Justin Schuh]

Fixed in http://trac.webkit.org/changeset/84653