Bug 60517 - [Chromium] Add rebaseline images for video-controls-rendering.
Summary: [Chromium] Add rebaseline images for video-controls-rendering.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: imasaki
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-09 16:47 PDT by imasaki
Modified: 2011-05-09 18:56 PDT (History)
4 users (show)

See Also:

Attachments
Patch (472.26 KB, patch)
2011-05-09 16:48 PDT, imasaki 		no flags Details | Formatted Diff | Diff
Patch (472.34 KB, patch)
2011-05-09 17:02 PDT, imasaki 		no flags Details | Formatted Diff | Diff
Patch (472.58 KB, patch)
2011-05-09 17:50 PDT, imasaki 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description imasaki 2011-05-09 16:47:19 PDT 
[Chromium] Add rebaseline images for video-controls-rendering.
Comment 1 imasaki 2011-05-09 16:48:24 PDT 
Created attachment 92885 [details]
Patch
Comment 2 imasaki 2011-05-09 17:02:23 PDT 
Created attachment 92887 [details]
Patch
Comment 3 David Levin 2011-05-09 17:42:49 PDT 
Comment on attachment 92887 [details]
Patch

The ChangeLog really doesn't provide enough information here.

It points to this bug http://code.google.com/p/chromium/issues/detail?id=74102 but that bug isn't fixed. Are we checking in a bad baseline so that we ensure no other problems occur (while bug 74102 is being fixed)?

This information would be helpful in the ChangeLog. (In general the ChangeLog should explain why this change is being done.)
Comment 4 imasaki 2011-05-09 17:50:46 PDT 
Created attachment 92895 [details]
Patch
Comment 5 WebKit Commit Bot 2011-05-09 18:52:39 PDT 
The commit-queue encountered the following flaky tests while processing attachment 92895 [details]:

http/tests/misc/favicon-loads-with-icon-loading-override.html bug 58412 (author: alice.liu@apple.com)
The commit-queue is continuing to process your patch.
Comment 6 WebKit Commit Bot 2011-05-09 18:56:13 PDT 
Comment on attachment 92895 [details]
Patch

Clearing flags on attachment: 92895

Committed r86121: <http://trac.webkit.org/changeset/86121>
Comment 7 WebKit Commit Bot 2011-05-09 18:56:18 PDT 
All reviewed patches have been landed.  Closing bug.