RESOLVED FIXED 60477
[Qt] Tab not working in editing/inserting/typing-tab-designmode-forms.html 
https://bugs.webkit.org/show_bug.cgi?id=60477
Summary [Qt] Tab not working in editing/inserting/typing-tab-designmode-forms.html
Chang Shu
Reported Monday, May 9, 2011 4:53:34 PM UTC
In the above test, type 'tab' should insert tab-space in the form. But it didn't happen.
Attachments
fix patch (3.14 KB, patch)
2011-05-10 10:54 PDT, Chang Shu 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chang Shu
Comment 1 Monday, May 9, 2011 4:54:57 PM UTC
editing/inserting/typing-tab-designmode.html seems to have the same problem.
Chang Shu
Comment 2 Tuesday, May 10, 2011 6:54:40 PM UTC
Created attachment 92982 [details] fix patch
Ryosuke Niwa
Comment 3 Wednesday, May 11, 2011 4:34:34 PM UTC
Comment on attachment 92982 [details] fix patch Looks sane to me but I guess someone from Qt port should review it.
Chang Shu
Comment 4 Wednesday, May 11, 2011 5:12:18 PM UTC
Comment on attachment 92982 [details] fix patch thanks, guys.
WebKit Commit Bot
Comment 5 Wednesday, May 11, 2011 5:54:20 PM UTC
The commit-queue encountered the following flaky tests while processing attachment 92982 [details]: http/tests/misc/favicon-loads-with-icon-loading-override.html bug 58412 (author: alice.liu@apple.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 6 Wednesday, May 11, 2011 5:59:25 PM UTC
Comment on attachment 92982 [details] fix patch Clearing flags on attachment: 92982 Committed r86243: <http://trac.webkit.org/changeset/86243>
WebKit Commit Bot
Comment 7 Wednesday, May 11, 2011 5:59:29 PM UTC
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 8 Wednesday, May 11, 2011 7:52:09 PM UTC
http://trac.webkit.org/changeset/86243 might have broken Windows XP Debug (Tests) The following tests are not passing: inspector/debugger/source-frame.html inspector/extensions/extensions.html media/controls-without-preload.html
Chang Shu
Comment 9 Wednesday, May 11, 2011 8:14:48 PM UTC
(In reply to comment #8) > http://trac.webkit.org/changeset/86243 might have broken Windows XP Debug (Tests) > The following tests are not passing: > inspector/debugger/source-frame.html > inspector/extensions/extensions.html > media/controls-without-preload.html The patch only touched Qt code.
Ademar Reis
Comment 10 Monday, May 16, 2011 10:04:04 PM UTC
Revision r86243 cherry-picked into qtwebkit-2.2 with commit 614ea61 <http://gitorious.org/webkit/qtwebkit/commit/614ea61>
Note You need to log in before you can comment on or make changes to this bug.