Bug 61034 - WebSocket: Use ScriptContext::Task to hold pending events of ThreadableWebSocketChannelClientWrapper
Summary: WebSocket: Use ScriptContext::Task to hold pending events of ThreadableWebSoc...
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yuta Kitamura
Depends on:
Blocks: 35721
  Show dependency treegraph
Reported: 2011-05-18 03:17 PDT by Yuta Kitamura
Modified: 2011-05-19 02:33 PDT (History)
3 users (show)

See Also:

Patch (7.32 KB, patch)
2011-05-18 03:22 PDT, Yuta Kitamura
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yuta Kitamura 2011-05-18 03:17:12 PDT
This is the third part of implementing WebSocket closing handshake (see bug 35721).

Remove m_pendingConnected, m_pendingMessages and m_pendingClosed from ThreadableWebSocketChannelClientWrapper, and use ScriptContext::Task to hold these pending events.
Comment 1 Yuta Kitamura 2011-05-18 03:22:57 PDT
Created attachment 93894 [details]
Comment 2 Kent Tamura 2011-05-18 18:39:35 PDT
Comment on attachment 93894 [details]

Looks good.
Comment 3 WebKit Commit Bot 2011-05-19 02:31:19 PDT
The commit-queue encountered the following flaky tests while processing attachment 93894 [details]:

http/tests/misc/favicon-loads-with-icon-loading-override.html bug 58412 (author: alice.liu@apple.com)
The commit-queue is continuing to process your patch.
Comment 4 WebKit Commit Bot 2011-05-19 02:33:28 PDT
Comment on attachment 93894 [details]

Clearing flags on attachment: 93894

Committed r86829: <http://trac.webkit.org/changeset/86829>
Comment 5 WebKit Commit Bot 2011-05-19 02:33:31 PDT
All reviewed patches have been landed.  Closing bug.