Bug 58573 - Since gcc 4.5.0, windows x64 symbols are not prefixed by underscore
Summary: Since gcc 4.5.0, windows x64 symbols are not prefixed by underscore
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-14 14:34 PDT by Fridrich Strba
Modified: 2011-04-15 18:21 PDT (History)
9 users (show)

See Also:


Attachments
Patch (1.49 KB, patch)
2011-04-14 14:38 PDT, Fridrich Strba
no flags Details | Formatted Diff | Diff
Patch (1.49 KB, patch)
2011-04-14 15:20 PDT, Fridrich Strba
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Fridrich Strba 2011-04-14 14:34:38 PDT
Fix this in JavaScriptCore
Comment 1 Fridrich Strba 2011-04-14 14:38:10 PDT
Created attachment 89649 [details]
Patch
Comment 2 WebKit Review Bot 2011-04-14 14:40:43 PDT
Attachment 89649 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1

Source/JavaScriptCore/jit/JITStubs.cpp:84:  Missing space after ,  [whitespace/comma] [3]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Fridrich Strba 2011-04-14 15:20:07 PDT
Created attachment 89669 [details]
Patch
Comment 4 WebKit Commit Bot 2011-04-15 16:33:14 PDT
The commit-queue encountered the following flaky tests while processing attachment 89669 [details]:

http/tests/misc/favicon-loads-with-icon-loading-override.html bug 58412 (author: alice.liu@apple.com)
http/tests/xmlhttprequest/failed-auth.html bug 51835 (author: ap@webkit.org)
The commit-queue is continuing to process your patch.
Comment 5 WebKit Commit Bot 2011-04-15 16:36:07 PDT
Comment on attachment 89669 [details]
Patch

Clearing flags on attachment: 89669

Committed r84048: <http://trac.webkit.org/changeset/84048>
Comment 6 WebKit Commit Bot 2011-04-15 16:36:11 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 WebKit Review Bot 2011-04-15 18:21:44 PDT
http://trac.webkit.org/changeset/84048 might have broken WinCairo Debug (Build)