Bug 85203 - [Qt] DumpRenderTree does not use 'monospace' font when directed
Summary: [Qt] DumpRenderTree does not use 'monospace' font when directed
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Caio Marcelo de Oliveira Filho
URL:
Keywords: Qt, QtTriaged
Depends on: 90809 91026 91084 91085 91086 91088 91090 91092 91093 91119 91132 91134 91140 91142 91234 91242 91246 91271 91378 91385 91397 91399 91400 91500 91501 91504 91570 91616 91621 91640 91739 91762 91856 91886 91902 91904 91905 91971 91985 91997 91999 92007 92013 92016 92023 92028 92038 92146 92149 92150 92174 92186 92274 92292
Blocks: 50144 77377 81899 86179 87501
  Show dependency treegraph
 
Reported: 2012-04-30 09:27 PDT by Dave Tharp
Modified: 2012-07-27 16:00 PDT (History)
22 users (show)

See Also:


Attachments
Reference test (1.28 KB, text/html)
2012-04-30 09:27 PDT, Dave Tharp
no flags Details
actual png generated on QT Linux bot (11.99 KB, image/png)
2012-04-30 09:28 PDT, Dave Tharp
no flags Details
expected png from GTK bot (9.25 KB, image/png)
2012-04-30 09:30 PDT, Dave Tharp
no flags Details
Screen capture of ref test running in QT test browser (8.42 KB, image/png)
2012-04-30 09:31 PDT, Dave Tharp
no flags Details
Patch for our testfonts.git repository, not for WebKit (10.34 KB, patch)
2012-05-25 08:08 PDT, Caio Marcelo de Oliveira Filho
no flags Details | Formatted Diff | Diff
And the complimentary patch for QtWebKit (1.57 KB, patch)
2012-05-29 08:35 PDT, Caio Marcelo de Oliveira Filho
no flags Details | Formatted Diff | Diff
List of tests that will need rebaseline (260.66 KB, text/plain)
2012-05-29 08:36 PDT, Caio Marcelo de Oliveira Filho
no flags Details
Patch for our testfonts.git repository, not for WebKit (1.71 MB, patch)
2012-07-02 13:52 PDT, Marcelo Lira
no flags Details | Formatted Diff | Diff
And the complimentary patch for QtWebKit (1.52 KB, patch)
2012-07-02 13:56 PDT, Marcelo Lira
no flags Details | Formatted Diff | Diff
Patch for our testfonts.git repository, not for WebKit (1.71 MB, patch)
2012-07-03 13:55 PDT, Marcelo Lira
no flags Details | Formatted Diff | Diff
And the complimentary patch for QtWebKit (239.99 KB, patch)
2012-07-03 14:08 PDT, Marcelo Lira
no flags Details | Formatted Diff | Diff
And the complimentary patch for QtWebKit (241.67 KB, patch)
2012-07-03 14:25 PDT, Marcelo Lira
no flags Details | Formatted Diff | Diff
failing tests on Qt 4.8 after these change (231.34 KB, text/plain)
2012-07-05 05:40 PDT, Csaba Osztrogonác
no flags Details
more failing tests on Qt 5.0 WK2 after these changes (7.09 KB, text/plain)
2012-07-05 05:52 PDT, Csaba Osztrogonác
no flags Details
And the complimentary patch for QtWebKit (241.53 KB, patch)
2012-07-05 08:52 PDT, Marcelo Lira
no flags Details | Formatted Diff | Diff
And the complimentary patch for QtWebKit (486.48 KB, patch)
2012-07-05 11:10 PDT, Marcelo Lira
no flags Details | Formatted Diff | Diff
Batch of reviewed expected results - animations and compositing (991.20 KB, patch)
2012-07-07 13:48 PDT, Luciano Wolf
no flags Details | Formatted Diff | Diff
Batch of reviewed expected txt results - animations and compositing (130.59 KB, patch)
2012-07-09 06:51 PDT, Luciano Wolf
no flags Details | Formatted Diff | Diff
Patch (595.49 KB, patch)
2012-07-12 10:15 PDT, Alex Bravo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Tharp 2012-04-30 09:27:22 PDT
Created attachment 139462 [details]
Reference test

Monospace font does not get used when running QT DRT.  Note that the monospace font does get used in the QT test browser.  

I'm attaching several files:

- a reference test that specifies monospace font
- png actual from run on QT Linux bots
- a png expected from the GTK bots (to show that monospace works there properly)
- a screen capture of the reference test running in the QT test browser.
Comment 1 Dave Tharp 2012-04-30 09:28:29 PDT
Created attachment 139463 [details]
actual png generated on QT Linux bot
Comment 2 Dave Tharp 2012-04-30 09:30:07 PDT
Created attachment 139464 [details]
expected png from GTK bot

To demonstrate what monospace should look like.
Comment 3 Dave Tharp 2012-04-30 09:31:10 PDT
Created attachment 139465 [details]
Screen capture of ref test running in QT test browser
Comment 4 Caio Marcelo de Oliveira Filho 2012-05-25 07:42:48 PDT
I'm working on this.
Comment 5 Caio Marcelo de Oliveira Filho 2012-05-25 08:08:19 PDT
Created attachment 144071 [details]
Patch for our testfonts.git repository, not for WebKit
Comment 6 Caio Marcelo de Oliveira Filho 2012-05-29 08:35:47 PDT
Created attachment 144566 [details]
And the complimentary patch for QtWebKit

This patch removes the special case for Qt5 WK1. We used to load another configuration file, but that won't be needed anymore.
Comment 7 Caio Marcelo de Oliveira Filho 2012-05-29 08:36:58 PDT
Created attachment 144567 [details]
List of tests that will need rebaseline

List of the 5347 tests needing rebaseline :P
Comment 8 Balazs Kelemen 2012-05-30 00:47:42 PDT
Nice improvement, now the conf file is much more readable (and I assume more reliable as well).
Comment 9 Marcelo Lira 2012-07-02 13:52:28 PDT
Created attachment 150469 [details]
Patch for our testfonts.git repository, not for WebKit
Comment 10 Marcelo Lira 2012-07-02 13:56:40 PDT
Created attachment 150472 [details]
And the complimentary patch for QtWebKit
Comment 11 Caio Marcelo de Oliveira Filho 2012-07-02 14:39:30 PDT
Comment on attachment 150472 [details]
And the complimentary patch for QtWebKit

Missing ChangeLog.
Comment 12 Caio Marcelo de Oliveira Filho 2012-07-02 14:45:20 PDT
(In reply to comment #11)
> (From update of attachment 150472 [details])
> Missing ChangeLog.

This patch should land with the additions to the Skipped too and mention the SHA-1 of the testfonts.git it depends. Maybe even create another bug with a more descriptive summary to land the WebKit change.
Comment 13 Csaba Osztrogonác 2012-07-03 05:00:34 PDT
Discussion about this bug on QtWebKit ML: http://lists.webkit.org/pipermail/webkit-qt/2012-May/002846.html

The plan in nutshell:
- skip affected tests (~5400 tests) (INdT guys)
- land patches in WebKit trunk and in testsfonts.git (INdT guys)
- unskip and rebase tests in ~500 sized batches (Szeged guys)
  
After rebaselining, we will have up-to-date png results for almost 
all tests. It's good time to try to start run pixel tests on the bots.
(It will be experiment first, because I'm not sure if png results will
be same (pixel by pixel) on 32/64 bit, on release/debug, on wk1/wk2.)

I only worry about the Qt 4.8 results a little bit. It would be great if
we can keep same results for Qt 4.8, Qt 5.0-WK1 and Qt 5.0-WK2 as the
actualities. At least until branching WebKit for productization and
drop supporting Qt 4.8 in trunk. I'm going to check if the new results
are same for these 3 platform today.

How does it sound?
Comment 14 Luciano Wolf 2012-07-03 05:48:46 PDT
Ossy, it sounds like a good plan. Talking to Alexis, there are 2 points that worth taking note:
- we need a proper wikipage describing "how to do" the unskip/rebase process so we can get more people involved;
- we have to keep all relevant comments from this mailing list thread and integrate into commit. It's a huge patch so we should keep as much information as possible without relying on links :)
Comment 15 Csaba Osztrogonác 2012-07-03 08:59:10 PDT
I made a quick experiment with the latest two patches (https://bugs.webkit.org/attachment.cgi?id=150469 and https://bugs.webkit.org/attachment.cgi?id=150472).
I applied them, run tests on qt-5.0-wk1 platform, 5448 tests failed. And then I generated new results for these tests to platform/qt and run tests on qt-5.0-wk2 and qt-4.8 platform. There are only ~400 failing tests on both of them. But maybe some of them are false positive, because there can be not updated results in qt-4.8 and qt-5.0-wk2 platform. So it seems we will be able handle differences.
Comment 16 Marcelo Lira 2012-07-03 13:55:52 PDT
Created attachment 150665 [details]
Patch for our testfonts.git repository, not for WebKit
Comment 17 Marcelo Lira 2012-07-03 14:08:24 PDT
Created attachment 150668 [details]
And the complimentary patch for QtWebKit
Comment 18 Marcelo Lira 2012-07-03 14:25:58 PDT
Created attachment 150669 [details]
And the complimentary patch for QtWebKit

Now with ChangeLogs. :-s
Comment 19 Rafael Brandao 2012-07-04 12:50:32 PDT
Comment on attachment 150669 [details]
And the complimentary patch for QtWebKit

View in context: https://bugs.webkit.org/attachment.cgi?id=150669&action=review

> LayoutTests/ChangeLog:3
> +        The test fonts used for Qt tests moved to the Liberation font family.

Maybe "were moved" instead of "moved"? Or "changed", like the comment you've added on Skipped list.

> LayoutTests/ChangeLog:6
> +        unskiped in batches, ASAP.

"unskipped".

> LayoutTests/ChangeLog:10
> +        https://bugs.webkit.org/show_bug.cgi?id=85203

ChangeLog format is wrong. You should have the bug title followed by the bug url and then the description of your patch.
Comment 20 Kenneth Rohde Christiansen 2012-07-04 19:34:34 PDT
Comment on attachment 150669 [details]
And the complimentary patch for QtWebKit

r- due to comments
Comment 21 Csaba Osztrogonác 2012-07-05 05:40:00 PDT
Created attachment 150927 [details]
failing tests on Qt 4.8 after these change

Here is the list of failing tests on Qt 4.8 with these 
patches. We should add them to platform/qt-4.8/Skipped.

My idea is that it makes unskipping work easily distributable. For example we grab 
500-500 tests per person, check them manually, update/add txt/png baselines to platform/qt.
I think the default platform/qt baseline should be Qt-5.0 WK1 results on Ubuntu 11.10 64bit inside XVFB.
And then other persons can check the few hundred exceptions for platform/qt-4.8 and platform/qt-5.0-wk2.

other pros/cons? maybe objections? :)
Comment 22 Csaba Osztrogonác 2012-07-05 05:52:58 PDT
Created attachment 150928 [details]
more failing tests on Qt 5.0 WK2 after these changes

Here is the failing tests on Qt 5.0 WK2 with the proposed patches and skipped tests.
Could you integrate this list and the Qt 4.8 list to the patch, please?
Comment 23 Bruno Abinader (history only) 2012-07-05 06:28:19 PDT
I can help with Qt5 / Ubuntu 11.10 32bit inside XVFB :)

(In reply to comment #21)
> Created an attachment (id=150927) [details]
> failing tests on Qt 4.8 after these change
> 
> Here is the list of failing tests on Qt 4.8 with these 
> patches. We should add them to platform/qt-4.8/Skipped.
> 
> My idea is that it makes unskipping work easily distributable. For example we grab 
> 500-500 tests per person, check them manually, update/add txt/png baselines to platform/qt.
> I think the default platform/qt baseline should be Qt-5.0 WK1 results on Ubuntu 11.10 64bit inside XVFB.
> And then other persons can check the few hundred exceptions for platform/qt-4.8 and platform/qt-5.0-wk2.
> 
> other pros/cons? maybe objections? :)
Comment 24 Marcelo Lira 2012-07-05 08:52:43 PDT
Created attachment 150948 [details]
And the complimentary patch for QtWebKit
Comment 25 Marcelo Lira 2012-07-05 11:10:55 PDT
Created attachment 150963 [details]
And the complimentary patch for QtWebKit
Comment 26 Csaba Osztrogonác 2012-07-06 05:52:29 PDT
Comment on attachment 150963 [details]
And the complimentary patch for QtWebKit

Can we wait Qt5 update, please? :)
Comment 27 Csaba Osztrogonác 2012-07-06 07:38:33 PDT
Comment on attachment 150963 [details]
And the complimentary patch for QtWebKit

Landed in https://trac.webkit.org/changeset/121971
Comment 28 Csaba Osztrogonác 2012-07-06 07:39:57 PDT
Comment on attachment 150665 [details]
Patch for our testfonts.git repository, not for WebKit

Landed in 558f3e7afab058def053a7149160c027a0e67aeb (git://gitorious.org/qtwebkit/testfonts.git)
Comment 29 Luciano Wolf 2012-07-07 13:48:21 PDT
Created attachment 151146 [details]
Batch of reviewed expected results - animations and compositing

I'm not sure about some files. They are listed inside Changelog file.
Comment 30 Luciano Wolf 2012-07-09 06:51:33 PDT
Created attachment 151246 [details]
Batch of reviewed expected txt results - animations and compositing

I'm not sure about some files. They are listed inside Changelog file. This patch includes only expected txt results, as proposed in mailing list.
Comment 31 Noam Rosenthal 2012-07-09 06:57:02 PDT
Comment on attachment 151246 [details]
Batch of reviewed expected txt results - animations and compositing

LGTM
Comment 32 Csaba Osztrogonác 2012-07-09 07:01:09 PDT
Could you wait a little bit with landing, please? I'm writing a detailed e-mail now.
Comment 33 Luciano Wolf 2012-07-09 11:56:13 PDT
Working on css1 directory.

The compositing directory has some chance of being updated later to make use of new WRT tests thing (new PNGs - discussed at #IRC and in a conversation with Caio). So I'm moving to css1 (next in line).
Comment 34 Alex Bravo 2012-07-11 18:00:34 PDT
I'll take html sub-directory.
Comment 35 Kristóf Kosztyó 2012-07-12 05:14:50 PDT
I'll take the css3 directory
Comment 36 Szilard Ledan 2012-07-12 05:16:07 PDT
I'll take css2.1/20110323 sub-directory (244 tests).
Comment 37 János Badics 2012-07-12 05:18:58 PDT
I'll take the fast/block dir
Comment 38 Ádám Kallai 2012-07-12 05:20:02 PDT
I'm working on editing/deleting test directory (121 tests)
Comment 39 Balazs Ankes 2012-07-12 05:20:31 PDT
I'll take editing/selection directory.
Comment 40 Kristóf Kosztyó 2012-07-12 06:39:49 PDT
I'm going to take svg/custom tests
Comment 41 Noam Rosenthal 2012-07-12 06:41:57 PDT
(In reply to comment #33)
> Working on css1 directory.
> 
> The compositing directory has some chance of being updated later to make use of new WRT tests thing (new PNGs - discussed at #IRC and in a conversation with Caio). So I'm moving to css1 (next in line).

I think we can safely rebase the text results for compositing and animations, and skip the pixel results until we're ready with https://bugs.webkit.org/show_bug.cgi?id=90394
Comment 42 Ádám Kallai 2012-07-12 07:57:25 PDT
I'm going to upadte all of the editing tests.
Comment 43 Balazs Ankes 2012-07-12 08:00:44 PDT
I did the svg/W3C-SVG-1.*.
Now Janos and I are going to take the tables directory.
Comment 44 Alex Bravo 2012-07-12 10:15:47 PDT
Created attachment 151986 [details]
Patch
Comment 45 Alex Bravo 2012-07-12 10:33:48 PDT
Comment on attachment 151986 [details]
Patch

I will create a different bug
Comment 46 Balazs Kelemen 2012-07-13 04:36:41 PDT
(In reply to comment #41)
> (In reply to comment #33)
> > Working on css1 directory.
> > 
> > The compositing directory has some chance of being updated later to make use of new WRT tests thing (new PNGs - discussed at #IRC and in a conversation with Caio). So I'm moving to css1 (next in line).
> 
> I think we can safely rebase the text results for compositing and animations, and skip the pixel results until we're ready with https://bugs.webkit.org/show_bug.cgi?id=90394

I go for compositing. I plan to first rebase text results, than push pixel results that are actually correct so later we can test the snapshot pixel results  with those.
Comment 47 Luciano Wolf 2012-07-13 13:17:15 PDT
Working on scrollbars, transforms, transitions directories
Comment 48 Balazs Ankes 2012-07-16 08:10:51 PDT
I'll take until fast/dom (except fast/block).
Comment 49 Bruno Abinader (history only) 2012-07-17 09:38:41 PDT
I'm taking fast/forms on bug 91504.
Comment 50 Szilard Ledan 2012-07-18 04:54:54 PDT
I'm going to take fast/css tests
Comment 51 Bruno Abinader (history only) 2012-07-18 06:18:49 PDT
Now taking fast/table directory on bug 91621.
Comment 52 Balazs Ankes 2012-07-18 07:09:06 PDT
I'm taking
- fast/dynamic
- fast/encoding
- fast/events
- fast/fast-mobile-scrolling
- fast/flexbox
- fast/frames
- fast/gradients
- fast/history
- fast/html
- fast/images
- fast/inline-block
- fast/inline
- fast/innerHTML
- fast/inspector-support
- fast/invalid
- fast/layers
- fast/line-grid
- fast/lists
- fast/media
- fast/multicol
Comment 53 Bruno Abinader (history only) 2012-07-18 10:42:16 PDT
Now taking fast/selectors directory on bug 91640.
Comment 54 Caio Marcelo de Oliveira Filho 2012-07-19 10:55:40 PDT
Taking svg/text, bug 91762.
Comment 55 Balazs Ankes 2012-07-20 06:41:10 PDT
I'm taking
- fast/overflow
- fast/parser
- fast/reflections
- fast/repaint
- fast/replaced
- fast/ruby
- fast/runin
- fast/spatial-navigation
- fast/text
- fast/tokenizer
- fast/transforms
- fast/writing-mode
- fast/xsl
(all of the remaining fast/* tests)
Comment 56 Szilard Ledan 2012-07-20 06:47:38 PDT
I'm taking
- svg/as-background-image
- svg/as-border-image
- svg/as-image
- svg/as-object
- svg/batik
- svg/carto.net
- svg/clip-path
- svg/css
- svg/custom (Kristof gave the results)
- svg/dom
- svg/filters
- svg/foreignObject
- svg/hixie

( bug 91856 )
Comment 57 Luciano Wolf 2012-07-20 11:27:16 PDT
taking ietestcenter (bug 91886)
Comment 58 Caio Marcelo de Oliveira Filho 2012-07-23 05:23:37 PDT
Taking editing/inserting, bug 91985.
Comment 59 Luciano Wolf 2012-07-23 07:32:08 PDT
taking animations - updating only text results, as previously discussed in this thread (bug 91997)
Comment 60 Balazs Ankes 2012-07-23 07:36:36 PDT
taking css2.1/t* (bug 91999)
Comment 61 Rafael Brandao 2012-07-23 09:16:34 PDT
(In reply to comment #60)
> taking css2.1/t* (bug 91999)

I'm taking editing/pasteboard on bug 91621.
Comment 62 Rafael Brandao 2012-07-23 09:17:11 PDT
(In reply to comment #61)
> (In reply to comment #60)
> > taking css2.1/t* (bug 91999)
> 
> I'm taking editing/pasteboard on bug 91621.

Sorry, I mean I`m taking editing/pasteboard on bug 92007. :P
Comment 63 Rafael Brandao 2012-07-23 09:23:31 PDT
(In reply to comment #62)
> (In reply to comment #61)
> > (In reply to comment #60)
> > > taking css2.1/t* (bug 91999)
> > 
> > I'm taking editing/pasteboard on bug 91621.
> 
> Sorry, I mean I`m taking editing/pasteboard on bug 92007. :P

It conflicted with kadam's work. Then I'll work on svg/zoom on bug 92007 if no one objects.
Comment 64 Caio Marcelo de Oliveira Filho 2012-07-23 11:33:23 PDT
Taking tables/mozilla_expected_failures, bug 92013.
Comment 65 Luciano Wolf 2012-07-23 12:19:56 PDT
taking platform, plugins and printing directories (bug 92016)
Comment 66 Rafael Brandao 2012-07-23 13:33:33 PDT
Taking the remaining svg: svg/{in-html,overflow,repaint,wicd} on bug 92023.
Comment 67 Caio Marcelo de Oliveira Filho 2012-07-23 14:18:55 PDT
Taking remaining dom/, bug 92028.
Comment 68 Caio Marcelo de Oliveira Filho 2012-07-23 15:37:54 PDT
Taking css3/selectors, bug 92038.
Comment 69 Alexis Menard (darktears) 2012-07-24 11:30:21 PDT
(In reply to comment #68)
> Taking css3/selectors, bug 92038.

Taking fast/borders
Comment 70 Luciano Wolf 2012-07-24 11:53:00 PDT
taking fast/block/basic directory
Comment 71 Luciano Wolf 2012-07-24 12:23:56 PDT
taking fast/block/float directory
Comment 72 Luciano Wolf 2012-07-24 14:20:50 PDT
(In reply to comment #69)
> (In reply to comment #68)
> > Taking css3/selectors, bug 92038.
> 
> Taking fast/borders

I'll continue the work on this one (fast/borders)
Comment 73 Caio Marcelo de Oliveira Filho 2012-07-24 16:19:15 PDT
Taking fast/block/positioning, bug 92174.
Comment 74 Bruno Abinader (history only) 2012-07-24 17:45:53 PDT
Taking editing/selection, bug 92186.
Comment 75 Luciano Wolf 2012-07-25 11:29:22 PDT
taking fast/block/margin-collapse (bug #92274)
Comment 76 Luciano Wolf 2012-07-25 13:31:50 PDT
taking editing/undo, fast/block/lineboxcontain and fast/js directories
Comment 77 Luciano Wolf 2012-07-25 14:31:55 PDT
(In reply to comment #76)
> taking editing/undo, fast/block/lineboxcontain and fast/js directories

also taking css3/filters and tables/layering (bug 92292)
Comment 78 Noam Rosenthal 2012-07-25 14:36:53 PDT
(In reply to comment #77)
> (In reply to comment #76)
> > taking editing/undo, fast/block/lineboxcontain and fast/js directories
> 
> also taking css3/filters and tables/layering (bug 92292)
For  now, don't rebaseline pixel results for anything under css3/filteres/*-hw.html. It's going to have different pixel results when switching to window snapshots.
Comment 79 Luciano Wolf 2012-07-26 07:06:38 PDT
(In reply to comment #78)
> (In reply to comment #77)
> > (In reply to comment #76)
> > > taking editing/undo, fast/block/lineboxcontain and fast/js directories
> > 
> > also taking css3/filters and tables/layering (bug 92292)
> For  now, don't rebaseline pixel results for anything under css3/filteres/*-hw.html. It's going to have different pixel results when switching to window snapshots.

Ok! Only updating a few text results (3) for css3/filters.
Comment 80 WebKit Review Bot 2012-07-27 05:01:07 PDT
Comment on attachment 151246 [details]
Batch of reviewed expected txt results - animations and compositing

Cleared Noam Rosenthal's review+ from obsolete attachment 151246 [details] so that this bug does not appear in http://webkit.org/pending-commit.
Comment 81 Caio Marcelo de Oliveira Filho 2012-07-27 16:00:35 PDT
DumpRenderTree and WebKitTestRunner now use monospace fonts when asked to. So I'll close this as fixed.

There's still a few tests that need to be triaged and bug 91610 was created to track them. They are identified in Qt's Skipped files.