Bug 91570 – [Qt] fast/text tests needs update after rebaseline and new testfonts

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Qt

[Bruno Abinader (history only)]

After the rebaseline from changeset 121971 - [Qt] DumpRenderTree does not use 'monospace' font when directed, fast/text tests directory needs to be updated.

[Bruno Abinader (history only)]

Created attachment 153001 [details]
Proposed patch

Proposed patch

[Simon Hausmann]

Comment on attachment 153001 [details]
Proposed patch

rs=me

[WebKit Review Bot]

Comment on attachment 153001 [details]
Proposed patch

Clearing flags on attachment: 153001

Committed r122971: <http://trac.webkit.org/changeset/122971>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Bruno Abinader (history only)]

3 new failing tests according to latest build:

http://build.webkit.sed.hu/builders/x86-32%20Linux%20Qt%20Release%20WebKit2/builds/26755/steps/layout-test

List of failing fast/text tests:
  fast/text/international/unicode-bidi-plaintext-in-textarea.html = TEXT
  fast/text/textIteratorNilRenderer.html = TEXT
  fast/text/whitespace/030.html = TEXT

I am having a double check at those atm.

[Bruno Abinader (history only)]

Created attachment 153295 [details]
Missing/Updated results patch

This patch fixes the faulty results for fast/text directory after r122985.

[Bruno Abinader (history only)]

Created attachment 153296 [details]
Missing/Updated results patch (+ ChangeLog)

Added missing ChangeLog.

[Bruno Abinader (history only)]

Created attachment 153302 [details]
Missing/Updated results patch (v2)

Fixed commit message with proper bug url.

[WebKit Review Bot]

Comment on attachment 153302 [details]
Missing/Updated results patch (v2)

Clearing flags on attachment: 153302

Committed r123144: <http://trac.webkit.org/changeset/123144>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Bruno Abinader (history only)]

Created attachment 154667 [details]
Re-skip and remove added tests on WK2 platform

This patch removes and re-skips the added tests for qt-5.0-wk2 layout test platform directory. As discussed with Caio, these tests should be assigned to proper bugs instead.

[Bruno Abinader (history only)]

Changing status back to "reopened".

[WebKit Review Bot]

Comment on attachment 154667 [details]
Re-skip and remove added tests on WK2 platform

Rejecting attachment 154667 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
fast/text/textIteratorNilRenderer-expected.txt
rm 'LayoutTests/platform/qt-5.0-wk2/fast/text/textIteratorNilRenderer-expected.txt'
LayoutTests/platform/qt-5.0/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.png: unknown git binary patch format at /mnt/git/webkit-commit-queue/Tools/Scripts/VCSUtils.pm line 1912.

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Noam Rosen..." exit_code: 29 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/13353864

[Bruno Abinader (history only)]

Created attachment 154698 [details]
Re-skip and remove added tests on WK2 platform (v2)

Rebased.

[Bruno Abinader (history only)]

Comment on attachment 154698 [details]
Re-skip and remove added tests on WK2 platform (v2)

Removing review flag as corrected by Alexis.

[WebKit Review Bot]

Comment on attachment 154698 [details]
Re-skip and remove added tests on WK2 platform (v2)

Rejecting attachment 154698 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
ayoutTests/platform/qt-5.0-wk2/fast/text/textIteratorNilRenderer-expected.txt
rm 'LayoutTests/platform/qt-5.0-wk2/fast/text/textIteratorNilRenderer-expected.txt'
LayoutTests/platform/qt-5.0/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.png: unknown git binary patch format at /mnt/git/webkit-commit-queue/Tools/Scripts/VCSUtils.pm line 1912.

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 29 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/13347970

[Bruno Abinader (history only)]

Created attachment 154746 [details]
Patch

[Bruno Abinader (history only)]

This time I´ve uploaded the patch using "webkit-patch" script, so in theory safer than generating through "git format-patch" and thus a hope against this weird "unknown git binary patch format" error message.

[Bruno Abinader (history only)]

Comment on attachment 154746 [details]
Patch

Igor applied the patch manually.

[Bruno Abinader (history only)]

Marking as "fixed".