Bug 91621 – [Qt] fast/table tests needs update after rebaseline and new testfonts

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Qt

[Bruno Abinader (history only)]

After the rebaseline from changeset 121971 - [Qt] DumpRenderTree does not use 'monospace' font when directed, fast/table tests directory needs to be updated.

[Bruno Abinader (history only)]

Created attachment 153025 [details]
Proposed patch

Proposed patch

[Alexis Menard (darktears)]

Comment on attachment 153025 [details]
Proposed patch

rs=me

[Alexis Menard (darktears)]

Comment on attachment 153025 [details]
Proposed patch

rs=me

[Bruno Abinader (history only)]

Created attachment 153027 [details]
Proposed patch (v2) - rebased to avoid conflicts

I've updated this patch as it might conflict with mainline due to old working tree of mine, now fixed.

[WebKit Review Bot]

Comment on attachment 153027 [details]
Proposed patch (v2) - rebased to avoid conflicts

Clearing flags on attachment: 153027

Committed r122985: <http://trac.webkit.org/changeset/122985>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Bruno Abinader (history only)]

4 new failing tests according to latest build:

http://build.webkit.sed.hu/builders/x86-32%20Linux%20Qt%20Release%20WebKit2/builds/26755/steps/layout-test

List of failing fast/table tests:
  fast/table/003.html = TEXT
  fast/table/colspanMinWidth.html = TEXT
  fast/table/spanOverlapRepaint.html = TEXT
  fast/table/text-field-baseline.html = TEXT

[Bruno Abinader (history only)]

Created attachment 153304 [details]
Missing/Updated results patch

This patch fixes the faulty results for fast/text directory after r122985.

[Bruno Abinader (history only)]

Created attachment 153310 [details]
Missing/Updated results patch (+ ChangeLog)

Yet another missing ChangeLog...

[Noam Rosenthal]

Comment on attachment 153310 [details]
Missing/Updated results patch (+ ChangeLog)

rs=me

[WebKit Review Bot]

Comment on attachment 153310 [details]
Missing/Updated results patch (+ ChangeLog)

Clearing flags on attachment: 153310

Committed r123229: <http://trac.webkit.org/changeset/123229>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Bruno Abinader (history only)]

Setting status back to "reopened".

[Bruno Abinader (history only)]

Created attachment 154673 [details]
Re-skip and remove added tests on WK2 platform

This patch removes and re-skips the added tests for qt-5.0-wk2 layout test platform directory. As discussed with Caio, these tests should be assigned to proper bugs instead.

[Kenneth Rohde Christiansen]

Comment on attachment 154673 [details]
Re-skip and remove added tests on WK2 platform

ok

[WebKit Review Bot]

Comment on attachment 154673 [details]
Re-skip and remove added tests on WK2 platform

Rejecting attachment 154673 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
t
rm 'LayoutTests/platform/qt-5.0-wk2/fast/table/spanOverlapRepaint-expected.txt'
rm 'LayoutTests/platform/qt-5.0-wk2/fast/table/text-field-baseline-expected.png'
patching file LayoutTests/platform/qt-5.0-wk2/fast/table/text-field-baseline-expected.txt
rm 'LayoutTests/platform/qt-5.0-wk2/fast/table/text-field-baseline-expected.txt'

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Kenneth Ro..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/13345832

[Bruno Abinader (history only)]

This patch should be merged after bug 91570 patch, as it touches the same Skipped file. Can you please take a look there as well?

[Bruno Abinader (history only)]

Comment on attachment 154673 [details]
Re-skip and remove added tests on WK2 platform

Noam granted r/cq flags to bug 91570, so requesting cq again for this.

[WebKit Review Bot]

Comment on attachment 154673 [details]
Re-skip and remove added tests on WK2 platform

Rejecting attachment 154673 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
t
rm 'LayoutTests/platform/qt-5.0-wk2/fast/table/spanOverlapRepaint-expected.txt'
rm 'LayoutTests/platform/qt-5.0-wk2/fast/table/text-field-baseline-expected.png'
patching file LayoutTests/platform/qt-5.0-wk2/fast/table/text-field-baseline-expected.txt
rm 'LayoutTests/platform/qt-5.0-wk2/fast/table/text-field-baseline-expected.txt'

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Kenneth Ro..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/13342899

[Bruno Abinader (history only)]

Created attachment 154703 [details]
Re-skip and remove added tests on WK2 platform (v2)

Rebased. Please notice this patch should land _after_ patch from bug 91570.

[Bruno Abinader (history only)]

Comment on attachment 154703 [details]
Re-skip and remove added tests on WK2 platform (v2)

Removing "cq" flag, as corrected by Alexis, until patch from bug 91570 gets landed.

[Bruno Abinader (history only)]

Igor landed the patch manually, marking as "fixed".