Bug 91501 - [Qt] svg/transforms tests needs update after rebaseline and new testfonts
Summary: [Qt] svg/transforms tests needs update after rebaseline and new testfonts
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Bruno Abinader (history only)
URL:
Keywords:
Depends on:
Blocks: 85203
  Show dependency treegraph
 
Reported: 2012-07-17 06:48 PDT by Bruno Abinader (history only)
Modified: 2012-07-18 05:39 PDT (History)
1 user (show)

See Also:


Attachments
Proposed patch (685.58 KB, patch)
2012-07-17 07:48 PDT, Bruno Abinader (history only)
menard: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Proposed patch (v2) + missing ChangeLog (687.40 KB, patch)
2012-07-17 14:02 PDT, Bruno Abinader (history only)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Bruno Abinader (history only) 2012-07-17 06:48:38 PDT
After the rebaseline proposed by Bug 85203 - [Qt] DumpRenderTree does not use 'monospace' font when directed, svg/transforms tests directory needs to be updated.
Comment 1 Bruno Abinader (history only) 2012-07-17 07:48:12 PDT
Created attachment 152761 [details]
Proposed patch

Proposed patch
Comment 2 Alexis Menard (darktears) 2012-07-17 07:55:19 PDT
Comment on attachment 152761 [details]
Proposed patch

rs=me.
Comment 3 WebKit Review Bot 2012-07-17 08:54:40 PDT
Comment on attachment 152761 [details]
Proposed patch

Rejecting attachment 152761 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
mit-queue/Source/WebKit/chromium/third_party/skia/src --revision 4552 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
45>At revision 4552.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/13276161
Comment 4 Bruno Abinader (history only) 2012-07-17 09:21:13 PDT
Did this patch actually caused this or just a chromium bot failure?

(In reply to comment #3)
> (From update of attachment 152761 [details])
> Rejecting attachment 152761 [details] from commit-queue.
> 
> Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2
> 
> Last 500 characters of output:
> mit-queue/Source/WebKit/chromium/third_party/skia/src --revision 4552 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
> 45>At revision 4552.
> 
> ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
> 
> ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
> Updating webkit projects from gyp files...
> 
> Full output: http://queues.webkit.org/results/13276161
Comment 5 Bruno Abinader (history only) 2012-07-17 09:33:54 PDT
Comment on attachment 152761 [details]
Proposed patch

Asking for commit queue again (previous denial sounds like a chromium bot-only issue).
Comment 6 WebKit Review Bot 2012-07-17 13:50:59 PDT
Comment on attachment 152761 [details]
Proposed patch

Rejecting attachment 152761 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
queue/Source/WebKit/chromium/third_party/sfntly/cpp/src --revision 134 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
43>At revision 134.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/13270251
Comment 7 Bruno Abinader (history only) 2012-07-17 14:02:10 PDT
Created attachment 152824 [details]
Proposed patch (v2) + missing ChangeLog

Sorry guys, somehow the ChangeLog got missing on this patch, fixed now.
Comment 8 Alexis Menard (darktears) 2012-07-17 14:21:02 PDT
Comment on attachment 152824 [details]
Proposed patch (v2) + missing ChangeLog

rs=me
Comment 9 WebKit Review Bot 2012-07-17 15:09:16 PDT
Comment on attachment 152824 [details]
Proposed patch (v2) + missing ChangeLog

Clearing flags on attachment: 152824

Committed r122878: <http://trac.webkit.org/changeset/122878>
Comment 10 WebKit Review Bot 2012-07-17 15:09:20 PDT
All reviewed patches have been landed.  Closing bug.