Bug 91093 – [Qt] platform/qt/fast/block tests needs update after rebaseline and new testfonts

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[János Badics]

Update test expectations. These tests are working correctly.

[János Badics]

Created attachment 151951 [details]
proposed patch

Updated test expectations. These tests are working fine now.

[Simon Hausmann]

Did you forget to set r? Is this intended for review/landing?

[János Badics]

I accidentally forgot to unskip these tests. Now I'm working on it. Patch will be uploaded soon. Sorry for the inconvenience

[János Badics]

Created attachment 153489 [details]
proposed patch

Unskipped the tests that have been rebased.

[Noam Rosenthal]

Comment on attachment 153489 [details]
proposed patch

rs=me

[WebKit Review Bot]

Comment on attachment 153489 [details]
proposed patch

Rejecting attachment 153489 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
/chromium/webkit --revision 147415 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
48>At revision 147415.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...
Total errors found: 0 in 0 files

Full output: http://queues.webkit.org/results/13311336

[János Badics]

Created attachment 153782 [details]
proposed patch

Changelog was obsolete. Updated patch

[Caio Marcelo de Oliveira Filho]

Comment on attachment 153782 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=153782&action=review

> LayoutTests/platform/qt-5.0/Skipped:723
> +fast/block/basic/020.html
> +fast/block/basic/fieldset-stretch-to-legend.html
> +fast/block/basic/text-indent-rtl.html

Please, create a different bug for the tests that are still failing and put in a separate section in the skipped list. This will make life easier for others doing the rebaseline of the remaining tests. Same comment applies to other skips added.

[Eric Seidel (no email)]

Comment on attachment 153489 [details]
proposed patch

Cleared Noam Rosenthal's review+ from obsolete attachment 153489 [details] so that this bug does not appear in http://webkit.org/pending-commit.

[Caio Marcelo de Oliveira Filho]

Comment on attachment 153782 [details]
proposed patch

This is not needed anymore. Other patches rebaselined those tests. Removing r?/cq?.