WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
91093
[Qt] platform/qt/fast/block tests needs update after rebaseline and new testfonts
https://bugs.webkit.org/show_bug.cgi?id=91093
Summary
[Qt] platform/qt/fast/block tests needs update after rebaseline and new testf...
János Badics
Reported
2012-07-12 07:22:46 PDT
Update test expectations. These tests are working correctly.
Attachments
proposed patch
(1.18 MB, patch)
2012-07-12 07:52 PDT
,
János Badics
no flags
Details
Formatted Diff
Diff
proposed patch
(1.19 MB, patch)
2012-07-20 06:13 PDT
,
János Badics
no flags
Details
Formatted Diff
Diff
proposed patch
(1.19 MB, patch)
2012-07-23 05:29 PDT
,
János Badics
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
János Badics
Comment 1
2012-07-12 07:52:23 PDT
Created
attachment 151951
[details]
proposed patch Updated test expectations. These tests are working fine now.
Simon Hausmann
Comment 2
2012-07-19 07:20:45 PDT
Did you forget to set r? Is this intended for review/landing?
János Badics
Comment 3
2012-07-19 07:23:13 PDT
I accidentally forgot to unskip these tests. Now I'm working on it. Patch will be uploaded soon. Sorry for the inconvenience
János Badics
Comment 4
2012-07-20 06:13:00 PDT
Created
attachment 153489
[details]
proposed patch Unskipped the tests that have been rebased.
Noam Rosenthal
Comment 5
2012-07-20 10:38:14 PDT
Comment on
attachment 153489
[details]
proposed patch rs=me
WebKit Review Bot
Comment 6
2012-07-20 11:12:20 PDT
Comment on
attachment 153489
[details]
proposed patch Rejecting
attachment 153489
[details]
from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: /chromium/webkit --revision 147415 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 48>At revision 147415. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Total errors found: 0 in 0 files Full output:
http://queues.webkit.org/results/13311336
János Badics
Comment 7
2012-07-23 05:29:01 PDT
Created
attachment 153782
[details]
proposed patch Changelog was obsolete. Updated patch
Caio Marcelo de Oliveira Filho
Comment 8
2012-07-23 11:20:23 PDT
Comment on
attachment 153782
[details]
proposed patch View in context:
https://bugs.webkit.org/attachment.cgi?id=153782&action=review
> LayoutTests/platform/qt-5.0/Skipped:723 > +fast/block/basic/020.html > +fast/block/basic/fieldset-stretch-to-legend.html > +fast/block/basic/text-indent-rtl.html
Please, create a different bug for the tests that are still failing and put in a separate section in the skipped list. This will make life easier for others doing the rebaseline of the remaining tests. Same comment applies to other skips added.
Eric Seidel (no email)
Comment 9
2012-07-27 01:10:23 PDT
Comment on
attachment 153489
[details]
proposed patch Cleared Noam Rosenthal's review+ from obsolete
attachment 153489
[details]
so that this bug does not appear in
http://webkit.org/pending-commit
.
Caio Marcelo de Oliveira Filho
Comment 10
2012-07-27 12:38:36 PDT
Comment on
attachment 153782
[details]
proposed patch This is not needed anymore. Other patches rebaselined those tests. Removing r?/cq?.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug