Bug 90809 - [Qt] [Part 1] platform/qt/css1 tests needs update after rebaseline and new testfonts
Summary: [Qt] [Part 1] platform/qt/css1 tests needs update after rebaseline and new te...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Luciano Wolf
URL:
Keywords:
Depends on:
Blocks: 85203 91026
  Show dependency tree / graph
 
Reported: 2012-07-09 11:51 PDT by Luciano Wolf
Modified: 2012-07-12 06:34 PDT (History)
1 user (show)

See Also:

Attachments
Batch of reviewed expected results - css1 (1.86 MB, patch)
2012-07-11 12:00 PDT, Luciano Wolf 		no flags Details | Formatted Diff | Diff
Patch for css1/box_properties directory (deleted)
2012-07-11 14:49 PDT, Luciano Wolf 		ossy: review+
Details | Formatted Diff | Diff
These files must be unskipped from qt-5.0-wk1 (2.53 KB, patch)
2012-07-12 06:10 PDT, Luciano Wolf 		no flags Details | Formatted Diff | Diff
box_properties test files skipped for wk1 and wk2 (5.06 KB, patch)
2012-07-12 06:16 PDT, Luciano Wolf 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Luciano Wolf 2012-07-09 11:51:05 PDT 
After the rebaseline proposed by Bug 85203 - [Qt] DumpRenderTree does not use 'monospace' font when directed, css1 tests directory needs to be updated. The  new expected results came from buildbot's output: https://lists.webkit.org/pipermail/webkit-qt/2012-July/002967.html
Comment 1 Luciano Wolf 2012-07-11 12:00:56 PDT 
Created attachment 151745 [details]
Batch of reviewed expected results - css1

First attempt on css1 directory patch.
Comment 2 Luciano Wolf 2012-07-11 12:56:17 PDT 
Comment on attachment 151745 [details]
Batch of reviewed expected results - css1

I tried to submit again using webkit-patch upload script but it doesn't send the patch. I don't know why it's not showing the image diffs properly under "Review patch" option.
Comment 3 Luciano Wolf 2012-07-11 14:15:16 PDT 
Comment on attachment 151745 [details]
Batch of reviewed expected results - css1

This bug has to be split into several parts due its huge size.
Comment 4 Luciano Wolf 2012-07-11 14:49:48 PDT 
Created attachment 151787 [details]
Patch for css1/box_properties directory
Comment 5 Csaba Osztrogonác 2012-07-12 05:49:22 PDT 
Comment on attachment 151787 [details]
Patch for css1/box_properties directory

LGTM, r=me. (all tests passed for me locally on wk1 and wk2 too)

But unfortunately images pass only on wk1, there are 30 tests (from 50) with image fail on WK2 with minor differences.

Please unskip them for wk1 and wk2 too. ;-) When we start running wk2 png tests, we can commit pngs for them.
Comment 6 Luciano Wolf 2012-07-12 06:10:04 PDT 
Created attachment 151931 [details]
These files must be unskipped from qt-5.0-wk1
Comment 7 Luciano Wolf 2012-07-12 06:16:34 PDT 
Created attachment 151932 [details]
box_properties test files skipped for wk1 and wk2
Comment 8 Csaba Osztrogonác 2012-07-12 06:33:40 PDT 
Landed in https://trac.webkit.org/changeset/122451