Bug 91234 - [Qt] compositing tests need rebaseline with new testfonts
Summary: [Qt] compositing tests need rebaseline with new testfonts
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Balazs Kelemen
URL:
Keywords:
Depends on:
Blocks: 85203
  Show dependency tree / graph
 
Reported: 2012-07-13 06:34 PDT by Balazs Kelemen
Modified: 2012-07-16 07:32 PDT (History)
3 users (show)

See Also:

Attachments
patch (1.48 MB, patch)
2012-07-13 08:28 PDT, Balazs Kelemen 		kbalazs: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Balazs Kelemen 2012-07-13 06:34:56 PDT 
Oh, yeah
Comment 1 Balazs Kelemen 2012-07-13 08:28:25 PDT 
Created attachment 152267 [details]
patch

I'm a bit confused. The tar Ossy created contained expectations in the generic platform/qt directory that are not exist currently. I checked Ossy's results with the rebaseline-server and every result was good. However, after I unskip the tests I still have font differences locally - a few with WebKit2 (13) and more with WebKit1 (34). Anyway I'm uploading this as I really curios whether I did what Ossy was planning or I did something wrong. The patch also contains pixel results because all of them was good too, so snapshot pixels (bug 90394) should be the same.
Anyway, we should double-check this test (probably on bots) before checking in.
Comment 2 Balazs Kelemen 2012-07-16 05:14:05 PDT 
Comment on attachment 152267 [details]
patch

Just baseline update, don't need review.
Comment 3 Balazs Kelemen 2012-07-16 07:32:41 PDT 
Landed in http://trac.webkit.org/changeset/122722