Bug 92186 - [Qt] editing/selection tests needs update after rebaseline and new testfonts
Summary: [Qt] editing/selection tests needs update after rebaseline and new testfonts
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Bruno Abinader (history only)
URL:
Keywords:
Depends on:
Blocks: 85203 91610 91990
  Show dependency treegraph
 
Reported: 2012-07-24 17:45 PDT by Bruno Abinader (history only)
Modified: 2012-07-26 08:52 PDT (History)
1 user (show)

See Also:


Attachments
Proposed patch (260.18 KB, patch)
2012-07-25 07:18 PDT, Bruno Abinader (history only)
no flags Details | Formatted Diff | Diff
Proposed patch (v2) (160.13 KB, patch)
2012-07-26 05:09 PDT, Bruno Abinader (history only)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Bruno Abinader (history only) 2012-07-24 17:45:04 PDT
After the rebaseline proposed by Bug 85203 - [Qt] DumpRenderTree does not use 'monospace' font when directed, editing/selection tests directory needs to be updated.
Comment 1 Bruno Abinader (history only) 2012-07-25 07:18:09 PDT
Created attachment 154347 [details]
Proposed patch

Proposed patch
Comment 2 Caio Marcelo de Oliveira Filho 2012-07-25 10:43:41 PDT
Comment on attachment 154347 [details]
Proposed patch

Removing ? since Bruno is working in a new version of the patch.
Comment 3 Bruno Abinader (history only) 2012-07-26 05:09:26 PDT
Created attachment 154615 [details]
Proposed patch (v2)

Updated patch with corrections suggested by Caio - instead of adding new WK2 results, skip them but in different bug lists accordingly (as bug 91990 and 91610).
Comment 4 Alexis Menard (darktears) 2012-07-26 06:59:04 PDT
Comment on attachment 154615 [details]
Proposed patch (v2)

OK
Comment 5 WebKit Review Bot 2012-07-26 08:52:09 PDT
Comment on attachment 154615 [details]
Proposed patch (v2)

Clearing flags on attachment: 154615

Committed r123750: <http://trac.webkit.org/changeset/123750>
Comment 6 WebKit Review Bot 2012-07-26 08:52:12 PDT
All reviewed patches have been landed.  Closing bug.