Bug 91399 - [Qt] platform/qt/editing/pasteboard tests needs update after rebaseline and new testfonts (75)
Summary: [Qt] platform/qt/editing/pasteboard tests needs update after rebaseline and n...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 85203
  Show dependency tree / graph
 
Reported: 2012-07-16 09:06 PDT by Ádám Kallai
Modified: 2012-07-27 04:12 PDT (History)
6 users (show)

See Also:

Attachments
proposed patch (deleted)
2012-07-16 09:17 PDT, Ádám Kallai 		no flags Details | Formatted Diff | Diff
proposed patch (deleted)
2012-07-23 05:17 PDT, Ádám Kallai 		no flags Details | Formatted Diff | Diff
proposed patch (deleted)
2012-07-24 05:01 PDT, Ádám Kallai 		no flags Details | Formatted Diff | Diff
proposed patch (deleted)
2012-07-25 07:05 PDT, Ádám Kallai 		ossy: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
proposed patch (deleted)
2012-07-26 09:05 PDT, Ádám Kallai 		webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
proposed patch (deleted)
2012-07-26 23:50 PDT, Ádám Kallai 		no flags Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ádám Kallai 2012-07-16 09:06:35 PDT 
I'm updating test expectations after font change.
Comment 1 Ádám Kallai 2012-07-16 09:17:21 PDT 
Created attachment 152549 [details]
proposed patch

I updated test expectations and png. I skipped a failing test.
Comment 2 Simon Hausmann 2012-07-19 07:21:55 PDT 
Did you forget to set r?
Comment 3 Caio Marcelo de Oliveira Filho 2012-07-19 09:27:22 PDT 
Fixing typo in the bug title.
Comment 4 Ádám Kallai 2012-07-23 01:56:02 PDT 
Sorry, I forgot to set r?. I'll fix it.
Comment 5 Ádám Kallai 2012-07-23 05:17:24 PDT 
Created attachment 153778 [details]
proposed patch

Update last patch.
Comment 6 Caio Marcelo de Oliveira Filho 2012-07-23 11:13:07 PDT 
Comment on attachment 153778 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=153778&action=review

> LayoutTests/platform/qt-5.0/Skipped:1552
> +editing/pasteboard/4944770-1.html
> +editing/pasteboard/4944770-2.html

Are these two still failing? They seem to work here.
Comment 7 Ádám Kallai 2012-07-24 01:31:27 PDT 
It's very interesting. These tests wasn't working, when I tested them therefore I left them on skippedlist.

I'm going to testing again. Maybe I was inattentive.
Comment 8 Ádám Kallai 2012-07-24 03:58:47 PDT 
You were right. :) Thanks for the review. I was inattentive. :( I added new expectations to platform/qt but these tests had some older expectations in qt-5.0-wk2 and qt-5.0 too. When I was testing it the script didn't consider platform/qt baseline directory.

Those expectations will be deleted and it will work fine.
Comment 9 Ádám Kallai 2012-07-24 05:01:11 PDT 
Created attachment 154023 [details]
proposed patch

I updated my patch. Now these tests are working well.
Comment 10 Ádám Kallai 2012-07-25 07:05:48 PDT 
Created attachment 154343 [details]
proposed patch

I think patch is ready. I hope it's working now. Could you have look at it please?
Comment 11 Csaba Osztrogonác 2012-07-25 07:15:47 PDT 
Comment on attachment 154343 [details]
proposed patch

rs=me
Comment 12 WebKit Review Bot 2012-07-25 07:21:41 PDT 
Comment on attachment 154343 [details]
proposed patch

Rejecting attachment 154343 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
s/platform/qt/editing/pasteboard/smart-paste-007-expected.txt
patching file LayoutTests/platform/qt/editing/pasteboard/styled-element-markup-expected.txt
patching file LayoutTests/platform/qt/editing/pasteboard/undoable-fragment-removes-expected.txt
patching file LayoutTests/platform/qt/editing/pasteboard/unrendered-br-expected.txt

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Csaba Oszt..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/13341254
Comment 13 Caio Marcelo de Oliveira Filho 2012-07-25 11:37:10 PDT 
Maybe the patch needs to be rebased?
Comment 14 Ádám Kallai 2012-07-26 09:05:44 PDT 
Created attachment 154663 [details]
proposed patch

I'm ready to update.
Comment 15 WebKit Review Bot 2012-07-26 11:22:34 PDT 
Comment on attachment 154663 [details]
proposed patch

Rejecting attachment 154663 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
ed.txt
patching file LayoutTests/platform/qt/editing/pasteboard/smart-paste-007-expected.txt
patching file LayoutTests/platform/qt/editing/pasteboard/styled-element-markup-expected.txt
patching file LayoutTests/platform/qt/editing/pasteboard/undoable-fragment-removes-expected.txt
patching file LayoutTests/platform/qt/editing/pasteboard/unrendered-br-expected.txt

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/13349870
Comment 16 Ádám Kallai 2012-07-26 23:50:11 PDT 
Created attachment 154856 [details]
proposed patch

Update.
Comment 17 WebKit Review Bot 2012-07-27 01:04:27 PDT 
Comment on attachment 154856 [details]
proposed patch

Rejecting attachment 154856 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

ERROR: /mnt/git/webkit-commit-queue/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/13361989
Comment 18 WebKit Review Bot 2012-07-27 04:12:01 PDT 
Comment on attachment 154856 [details]
proposed patch

Clearing flags on attachment: 154856

Committed r123862: <http://trac.webkit.org/changeset/123862>
Comment 19 WebKit Review Bot 2012-07-27 04:12:05 PDT 
All reviewed patches have been landed.  Closing bug.