Bug 75793

Summary: [meta] DOMWindow::m_securityOrigin must die!
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, eric, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 27640, 75794, 75795, 75796, 75797, 75838, 77537, 93016, 93025, 93038, 93041, 93049, 93072, 93079, 93140, 93307, 93323, 93382, 93407, 93660, 93666, 93987, 93989, 93990, 93991, 93993, 94052    
Bug Blocks: 93095    
Attachments:
Description Flags
crazy large proof-of-concept none

Description Adam Barth 2012-01-08 01:52:11 PST
[meta] DOMWindow::m_securityOrigin must die
Comment 1 Adam Barth 2012-01-08 01:53:02 PST
Created attachment 121574 [details]
crazy large proof-of-concept
Comment 2 Adam Barth 2012-01-08 01:55:17 PST
It's crazy that DOMWindow has its own secret version of m_securityOrigin.  We should only have one canonical place to store that state (which is the SecurityContext base class).

Unfortunately, removing this state triggers a massive yak shave to move a lot of bindings code away from using DOMWindow as a context object and towards using ScriptExecutionContext, which is the right thing anyway.

I'll post the real patches on separate bugs that block this one.
Comment 3 Adam Barth 2012-08-02 11:09:22 PDT
I'm going to try this again.  I'm going to take a somewhat long path to make this happen, but hopefully I'll improve a bunch of things about the bindings along the way.
Comment 4 Adam Barth 2012-08-14 13:18:22 PDT
As of <http://trac.webkit.org/changeset/125592>, DOMWindow::m_securityOrigin is now dead.  I'm going to use this meta bug to various related cleanup patches now that we're "over the hump."
Comment 5 Dimitri Glazkov (Google) 2012-08-14 13:43:20 PDT
(In reply to comment #4)
> As of <http://trac.webkit.org/changeset/125592>, DOMWindow::m_securityOrigin is now dead.  I'm going to use this meta bug to various related cleanup patches now that we're "over the hump."

Whoa.