Bug 68012
| Summary: | [meta] WebKit has too many #if defines, particularly ENABLE() macro usage | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> |
| Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | abarth, cmarcelo, darin, dbates, dglazkov, efidler, jchaffraix, laszlo.gombos, mjs, thakis, tonikitoo |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 68018, 68019, 68022, 68179, 68182, 68205, 68290, 68292, 68407, 68414, 68759, 68765, 68767, 68771, 68774, 68779, 69729, 70187, 70189, 70191, 70192, 70194, 70216, 70217 | ||
| Bug Blocks: | |||
Eric Seidel (no email)
[meta] WebKit has too many #if defines, particularly ENABLE() macro usage
Here is a google Doc we've been using for tracking:
https://docs.google.com/spreadsheet/ccc?key=0AlC4tS7Ao1fIdHFVNUpFSDBudEF5WGM3WDNzQjI3Ync&authkey=CJCDiooK&hl=en_US#gid=0
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Adam Barth
The spreadsheet is a bit hard to manage because it contains every ENABLE macro. Here is a more focused document about just what we're planning to change in this round:
https://docs.google.com/document/d/1MVbOTYkZxTj071-ZQI7Lsh7CdZJhS2_1OdU4bjYuaKA/edit?hl=en_US
Everyone should be able to comment. If you'd like edit access, please let me know.
Adam Barth
Obviously there's still more we can do here, but we've made a lot of progress. I'll send a summary email to webkit-dev.