Always enable ENABLE(OFFLINE_WEB_APPLICATIONS)
Created attachment 108591 [details] Patch
Comment on attachment 108591 [details] Patch Attachment 108591 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9842415
Created attachment 108593 [details] Patch
Comment on attachment 108593 [details] Patch Attachment 108593 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/9841421
Created attachment 108594 [details] Patch
Committed r95919: <http://trac.webkit.org/changeset/95919>
(In reply to comment #6) > Committed r95919: <http://trac.webkit.org/changeset/95919> It broke all ENABLE_SQL_DATABASE=0 build, for example Qt Linux Release minimal core builder bot: http://build.webkit.org/builders/Qt%20Linux%20Release%20minimal/builds/33061 I think after this patch we should remove ENABLE_SQL_DATABASE guards too.
Comment on attachment 108594 [details] Patch landed patch
> I think after this patch we should remove ENABLE_SQL_DATABASE guards too. We probably should narrow the scope of that enable. It looks like we need SQLiteStatement and friends, but we still want folks to be able to turn off the SQL database web API. That's something of a dead-end API that folks might not wish to ship.
Reopen until a proper fix.
(In reply to comment #9) > > I think after this patch we should remove ENABLE_SQL_DATABASE guards too. > > We probably should narrow the scope of that enable. It looks like we need SQLiteStatement and friends, but we still want folks to be able to turn off the SQL database web API. That's something of a dead-end API that folks might not wish to ship. I don't understand what do you think. You made OFFLINE_WEB_APPLICATIONS always enabled. And application cache need SQL. How would you like to make OFFLINE_WEB_APPLICATIONS work without SQL?
> I don't understand what do you think. You made OFFLINE_WEB_APPLICATIONS always enabled. And application cache need SQL. How would you like to make OFFLINE_WEB_APPLICATIONS work without SQL? ENABLE_SQL_DATABASE isn't really about enabling the SQLite library. That's something like USE(SQLITE) or something. ENABLE_SQL_DATABASE is about enabling or disabling the WebSQLDatabase API. Your approach in Bug 68902 is great.
It appears that ApplicationCacheStorage can't be built without sqlite; or at least it won't be useful. It's really undesirable to require sqlite in order to build WebKit.
> It's really undesirable to require sqlite in order to build WebKit. Why? As far as I can tell, everyone builds with SQLite anyway.
(In reply to comment #14) > > It's really undesirable to require sqlite in order to build WebKit. > > Why? As far as I can tell, everyone builds with SQLite anyway. For embedding purposes, not everyone can afford to ship with SQLite.
I'm inclined to wait for someone who's working on an embedded browser to make that argument. At the moment, your concern sounds more theoretical than a real problem you're facing.
(In reply to comment #16) > I'm inclined to wait for someone who's working on an embedded browser to make that argument. At the moment, your concern sounds more theoretical than a real problem you're facing. I know someone porting WebKit to a non-UNIX operating system, and he's facing this problem since SQLite hasn't been ported to his operating system yet.