Bug 70192 - Remove unused ENABLE(SKIA_GPU)
Summary: Remove unused ENABLE(SKIA_GPU)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 68012
  Show dependency tree / graph
 
Reported: 2011-10-15 19:08 PDT by Adam Barth
Modified: 2013-03-28 20:24 PDT (History)
8 users (show)

See Also:

Attachments
Patch (1.31 KB, patch)
2011-10-15 19:09 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2011-10-15 19:08:35 PDT 
Remove unused ENABLE(SKIA_GPU)
Comment 1 Adam Barth 2011-10-15 19:09:29 PDT 
Created attachment 111163 [details]
Patch
Comment 2 Daniel Bates 2011-10-15 19:42:22 PDT 
Comment on attachment 111163 [details]
Patch

For completeness, references to ENABLE(SKIA_GPU) were replaced with USE(SKIA) or an analogous run-time check in <http://trac.webkit.org/changeset/85017>. Obviously, we didn't remove SKIA_GPU references in Source/WebKit/chromium/features.gypi.
Comment 3 WebKit Review Bot 2011-10-15 21:19:03 PDT 
Comment on attachment 111163 [details]
Patch

Clearing flags on attachment: 111163

Committed r97570: <http://trac.webkit.org/changeset/97570>
Comment 4 WebKit Review Bot 2011-10-15 21:19:07 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Kang-Hao (Kenny) Lu 2013-03-28 20:24:54 PDT 
(In reply to comment #2)
> (From update of attachment 111163 [details])
> For completeness, references to ENABLE(SKIA_GPU) were replaced with USE(SKIA) or an analogous run-time check in <http://trac.webkit.org/changeset/85017>. Obviously, we didn't remove SKIA_GPU references in Source/WebKit/chromium/features.gypi.

It seems that ENABLE_RUBY, introduced temporarily by Bug 28420, was not removed from features.gypi either. I am not sure about ENABLE_SANDBOX, V8_SCRIPT_DEBUG_SERVER. These two were introduced in r88548 but there are not listed on http://trac.webkit.org/wiki/FeatureFlags .